APP-3604 build endpoints for external oauth and repos #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abe-winter
changed the title
abe-winter
added
the
ready-for-protos
abe-winter
removed
the
ready-for-protos
ale7714
reviewed
Aug 14, 2024
| // git repo in owner/repository form | ||
| string repo = 5; | ||
| // email of the viam user who created this | ||
| string viam_user = 6; |
There was a problem hiding this comment.
Will it be an issue if the viam user is deleted?
There was a problem hiding this comment.
this is just for tracking history; the authorization is done through the OAuth app link, which is permissioned per viam org
proto/viam/app/build/v1/build.proto
Outdated
| @@ -83,3 +99,74 @@ message ListJobsResponse { | |||
| // jobs is ordered by (build start time, alphabetical platform). | |||
| repeated JobInfo jobs = 1; | |||
| } | |||
|
|
|||
| message RepoLink { | |||
| string app_link_id = 1; | |||
There was a problem hiding this comment.
if it is, can we call oauth_app_link id or something? so it's a bit more clear where it comes from
There was a problem hiding this comment.
yup way clearer, done in 33c41a0
abe-winter
added
the
ready-for-protos
zaporter-work
approved these changes
Aug 14, 2024
Comment on lines
+148
to
+149
| // list of org public namespace (where available) or org UUIDs attached to the external app | ||
| repeated string org_id_or_ns = 4; |
There was a problem hiding this comment.
To support one user attaching multiple orgs to the same app?
There was a problem hiding this comment.
yes -- main motivation for this was our internal use pattern
proto/viam/app/build/v1/build.proto
Outdated
Comment on lines
108
to
109
| // public namespace of the module | ||
| optional string namespace = 3; |
There was a problem hiding this comment.
[probably worth discussing] Why is associating the namespace necessary for this message (same for AppLink)?
I worry that this will mean that will add a lot more logic & edge cases for module transfers from org to org.
There was a problem hiding this comment.
this is populated in the downstream direction so that CLI output is user-readable; it's not stored in the DB and it's not used in the request. I'll edit the docstring to say this
abe-winter
removed
the
ready-for-protos
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Pranav Puranam <pranav.puranam@gmail.com>
abe-winter
added
protos-compiled
ready-for-protos
abe-winter
removed
the
ready-for-protos
abe-winter
added
the
ready-for-protos
abe-winter
removed
the
ready-for-protos
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Why
Linking our build service to source control / CI is currently bad; it's super unintuitive and doesn't work with private repos. These endpoints let us use native oauth tools provided by git hosts for something closer to one-click setup. (no more yamls! no need to set up viam credentials).
Note the new endpoints are experimental (the entire build service is still marked as 'subject to change'). They don't work yet and should only be hit by the viam CLI, not external users.