Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about skipping upstream cache during revalidation #38014

Merged
merged 4 commits into from
Jun 25, 2022
Merged

Add note about skipping upstream cache during revalidation #38014

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70b17dd
Add note about skipping upstream cache during revalidation
ijjk Jun 25, 2022
a60ded5
Update docs/basic-features/data-fetching/incremental-static-regenerat…
leerob Jun 25, 2022
bead242
tweak a bit more
ijjk Jun 25, 2022
d36a2c6
Update docs/basic-features/data-fetching/incremental-static-regenerat…
leerob Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/basic-features/data-fetching/incremental-static-regeneration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ When a request is made to a page that was pre-rendered at build time, it will in

When a request is made to a path that hasn’t been generated, Next.js will server-render the page on the first request. Future requests will serve the static file from the cache. ISR on Vercel [persists the cache globally and handles rollbacks](https://vercel.com/docs/concepts/next.js/incremental-static-regeneration).

> Note: Check if your upstream data provider has caching enabled by default. You might need to disable (e.g. `useCdn: false`), otherwise a revalidation won't be able to pull fresh data to update the Next.js cache. When using Next.js on Vercel, caching is enabled by default through the Vercel Edge Network.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly modified - thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using Next.js on Vercel, caching is enabled by default through the Vercel Edge Network

Is this referring to API routes, as caching isn't enabled by default there unless the cache-control header is set. Also not sure how common it is to fetch from a Vercel endpoint during a revalidation instead of database or CMS like Contentful

Copy link
Member Author

@ijjk ijjk Jun 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked a bit more in bead242 wdyt?


## On-demand Revalidation

If you set a `revalidate` time of `60`, all visitors will see the same generated version of your site for one minute. The only way to invalidate the cache is from someone visiting that page after the minute has passed.
Expand Down