Add note about skipping upstream cache during revalidation #38014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
timneutkens,
shuding,
styfle,
huozhi,
padmaia,
leerob and
balazsorban44
as code owners
ijjk
added
area: documentation
created-by: Next.js team
1 task
styfle
reviewed
Jun 25, 2022
docs/basic-features/data-fetching/incremental-static-regeneration.md
Outdated
Show resolved
Hide resolved
…ion.md Co-authored-by: Steven <steven@ceriously.com>
leerob
reviewed
Jun 25, 2022
| @@ -88,6 +88,8 @@ When a request is made to a page that was pre-rendered at build time, it will in | |||
|
|
|||
| When a request is made to a path that hasn’t been generated, Next.js will server-render the page on the first request. Future requests will serve the static file from the cache. ISR on Vercel [persists the cache globally and handles rollbacks](https://vercel.com/docs/concepts/next.js/incremental-static-regeneration). | |||
|
|
|||
| > Note: Check if your upstream data provider has caching enabled by default. You might need to disable (e.g. `useCdn: false`), otherwise a revalidation won't be able to pull fresh data to update the Next.js cache. When using Next.js on Vercel, caching is enabled by default through the Vercel Edge Network. | |||
There was a problem hiding this comment.
When using Next.js on Vercel, caching is enabled by default through the Vercel Edge Network
Is this referring to API routes, as caching isn't enabled by default there unless the cache-control header is set. Also not sure how common it is to fetch from a Vercel endpoint during a revalidation instead of database or CMS like Contentful
There was a problem hiding this comment.
Tweaked a bit more in bead242 wdyt?
leerob
reviewed
Jun 25, 2022
docs/basic-features/data-fetching/incremental-static-regeneration.md
Outdated
Show resolved
Hide resolved
leerob
approved these changes
Jun 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note about ensuring requests during a revalidation don't leverage an upstream cache as it will fail to pull fresh data to update the ISR cache with if configured.
Documentation / Examples
pnpm lintFixes: #35523 (comment)
x-ref: #35195