Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deploy E2E test setup #37126

Merged
merged 18 commits into from
May 23, 2022
Merged

Update deploy E2E test setup #37126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
01f37ce
Update deploy E2E test setup
ijjk May 23, 2022
9d49cb5
fix typo
ijjk May 23, 2022
756bd87
update
ijjk May 23, 2022
d54d386
bump
ijjk May 23, 2022
66dbf19
update
ijjk May 23, 2022
e66299b
fix var
ijjk May 23, 2022
039f49d
specific test
ijjk May 23, 2022
4822b74
run all
ijjk May 23, 2022
51662ff
debug
ijjk May 23, 2022
16254df
update test
ijjk May 23, 2022
9ba82d9
Merge branch 'canary' into fix/e2e-deploy
ijjk May 23, 2022
6739160
log
ijjk May 23, 2022
d841dc5
use test binary
ijjk May 23, 2022
4a4239e
update config
ijjk May 23, 2022
145fcc5
stabilize test
ijjk May 23, 2022
22b2166
update test
ijjk May 23, 2022
46280e9
Merge branch 'canary' into fix/e2e-deploy
ijjk May 23, 2022
5c48345
undo test check
ijjk May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build_test_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,8 @@ jobs:
testDeployE2E:
name: E2E (deploy)
runs-on: ubuntu-latest
needs: [publishRelease]
# todo revert after testing
needs: [build]
env:
NEXT_TELEMETRY_DISABLED: 1
NEXT_TEST_JOB: 1
Expand Down
7 changes: 6 additions & 1 deletion run-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,12 @@ async function main() {
)
})

if ((testType && testType !== 'unit') || hasIsolatedTests) {
if (
(testType &&
testType !== 'unit' &&
!process.env.NEXT_TEST_MODE === 'deploy') ||
ijjk marked this conversation as resolved.
Show resolved Hide resolved
hasIsolatedTests
) {
// for isolated next tests: e2e, dev, prod we create
// a starter Next.js install to re-use to speed up tests
// to avoid having to run yarn each time
Expand Down
3 changes: 2 additions & 1 deletion test/lib/next-modes/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ export class NextInstance {
process.env.NEXT_TEST_STARTER &&
!this.dependencies &&
!this.installCommand &&
!this.packageJson
!this.packageJson &&
!(global as any).isNextDeploy
) {
await fs.copy(process.env.NEXT_TEST_STARTER, this.testDir)
} else if (!skipIsolatedNext) {
Expand Down