Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deploy E2E test setup #37126

Merged
merged 18 commits into from
May 23, 2022
Merged

Update deploy E2E test setup #37126

merged 18 commits into from
May 23, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 23, 2022 •
edited
Loading

Fixes E2E deploy tests as they were failing from the swc dev binary not being present for jest transpiling and skips some tests that need to be investigated/aren't expected to be working currently

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label May 23, 2022
almeidx
almeidx reviewed May 23, 2022
View reviewed changes
run-tests.js Outdated Show resolved Hide resolved
@ijjk
Copy link
Member Author

ijjk commented May 23, 2022 •
edited
Loading

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
buildDuration 14.5s 14.3s -179ms
buildDurationCached 5.7s 5.8s ⚠️ +148ms
nodeModulesSize 479 MB 479 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.516 3.538 ⚠️ +0.02
/ avg req/sec 711.05 706.61 ⚠️ -4.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.233 1.273 ⚠️ +0.04
/error-in-render avg req/sec 2027.67 1963.43 ⚠️ -64.24
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 73 kB 73 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.73 kB 5.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 529 B 529 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
buildDuration 16.3s 16.1s -176ms
buildDurationCached 5.7s 5.8s ⚠️ +173ms
nodeModulesSize 479 MB 479 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.535 3.698 ⚠️ +0.16
/ avg req/sec 707.17 676.05 ⚠️ -31.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.223 1.279 ⚠️ +0.06
/error-in-render avg req/sec 2043.63 1955.02 ⚠️ -88.61
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.7 kB 29.7 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 74.1 kB 74.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.82 kB 5.82 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.78 kB 2.78 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/e2e-deploy Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 5c48345

@ijjk ijjk marked this pull request as ready for review May 23, 2022 22:05
styfle
styfle reviewed May 23, 2022
View reviewed changes
test/e2e/i18n-data-fetching-redirect/index.test.ts
@@ -7,6 +7,12 @@ import webdriver from 'next-webdriver'
describe('i18n-data-fetching-redirect', () => {
let next: NextInstance

// TODO: investigate tests failures on deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to merge this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this will need to be investigated separately

styfle
styfle reviewed May 23, 2022
View reviewed changes
test/lib/e2e-utils.ts
@@ -46,7 +46,9 @@ if (testModeFromFile === 'e2e') {
const validE2EModes = ['dev', 'start', 'deploy']

if (!process.env.NEXT_TEST_JOB && !testMode) {
console.warn('Warn: no NEXT_TEST_MODE set, using default of start')
require('console').warn(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the purpose of require() here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it bypasses jest delaying the logs from being emitted, x-ref: #35507

@ijjk ijjk requested a review from styfle May 23, 2022 22:35
@ijjk ijjk merged commit 81850eb into canary May 23, 2022
@ijjk ijjk deleted the fix/e2e-deploy branch May 23, 2022 22:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@almeidx almeidx almeidx left review comments

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @styfle @almeidx