Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-helpful error in with-sentry example #36902

Merged
merged 1 commit into from
May 13, 2022
Merged

Remove un-helpful error in with-sentry example #36902

merged 1 commit into from
May 13, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 13, 2022 •
edited
Loading

The error reported here is unclear and un-helpful so we shouldn't be recommending to report this by default.

x-ref: slack thread

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team. labels May 13, 2022
leerob
leerob approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit 167a91b into vercel:canary May 13, 2022
@ijjk ijjk deleted the example/with-sentry branch May 14, 2022 03:06
@smeubank smeubank mentioned this pull request May 19, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@leerob leerob leerob approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @huozhi @leerob