Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to report when throwing an non-error value #5131

Closed
smeubank opened this issue May 19, 2022 · 2 comments
Closed

What to report when throwing an non-error value #5131

smeubank opened this issue May 19, 2022 · 2 comments
Assignees
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK Type: Improvement

Comments

@smeubank
Copy link
Member

Problem Statement

Stemming from a discussion in discord and subsequent conversations with Vercel:

image

this can be caused by the throw null throw 0 throw undefined which would cause this line if (err) to not proceed

That’s why we’re stripping the confusing error message we were adding, but what’s your recommendation ?

Solution Brainstorm

Vercel has fixed to remove the unhelpful error in the example repo already
vercel/next.js#36902

we could do a captureMessage

@smeubank smeubank added Type: Improvement Package: nextjs Issues related to the Sentry Nextjs SDK labels May 19, 2022
@smeubank smeubank added this to the NextJS Improvements milestone May 19, 2022
@smeubank smeubank added the Jira label May 19, 2022
@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@vladanpaunovic
Copy link
Contributor

Fixed in #5259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK Type: Improvement
Projects
None yet
Development

No branches or pull requests

3 participants