Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disabled tests that pass #36644

Merged
merged 1 commit into from
May 3, 2022
Merged

Enable disabled tests that pass #36644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions test/e2e/root-dir/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import path from 'path'
import cheerio from 'cheerio'
import webdriver from 'next-webdriver'

// TODO: implementation
describe.skip('root dir', () => {
describe('root dir', () => {
let next: NextInstance

beforeAll(async () => {
Expand Down Expand Up @@ -127,12 +126,13 @@ describe.skip('root dir', () => {

// TODO: do we want to make this only work for /root or is it allowed
// to work for /pages as well?
it('should match partial parameters', async () => {
it.skip('should match partial parameters', async () => {
const html = await renderViaHTTP(next.url, '/partial-match-123')
expect(html).toContain('hello from root/partial-match-[id]. ID is: 123')
})

describe('parallel routes', () => {
// TODO: Implement
describe.skip('parallel routes', () => {
describe('conditional routes', () => {
it('should serve user page', async () => {
const html = await renderViaHTTP(next.url, '/conditional/tim')
Expand Down Expand Up @@ -229,7 +229,8 @@ describe.skip('root dir', () => {
expect(html).toContain('hello from root/shared-component-route')
})

it('should serve client component', async () => {
// TODO: implement
it.skip('should serve client component', async () => {
const html = await renderViaHTTP(next.url, '/client-component-route')
expect(html).toContain('hello from root/client-component-route. count: 0')

Expand All @@ -240,7 +241,8 @@ describe.skip('root dir', () => {
)
})

it('should include client component layout with server component route', async () => {
// TODO: implement
it.skip('should include client component layout with server component route', async () => {
const html = await renderViaHTTP(next.url, '/client-nested')
const $ = cheerio.load(html)
// Should not be nested in dashboard
Expand Down