Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disabled tests that pass #36644

Merged
merged 1 commit into from
May 3, 2022
Merged

Enable disabled tests that pass #36644

merged 1 commit into from
May 3, 2022

Conversation

timneutkens
Copy link
Member

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label May 3, 2022
@ijjk
Copy link
Member

ijjk commented May 3, 2022

Failing test suites

Commit: 94b9a28

yarn testheadless test/integration/amphtml/test/index.test.js

  • AMP Usage > AMP dev mode > should detect the changes and display it
  • AMP Usage > AMP dev mode > should detect changes to component and refresh an AMP page
  • AMP Usage > AMP dev mode > should detect changes and refresh a hybrid AMP page
Expand output

● AMP Usage › AMP dev mode › should detect the changes and display it

TIMED OUT: /This is the hot AMP page/

This is a cold AMP page.

no AMP for you...

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:369:9)

● AMP Usage › AMP dev mode › should detect changes to component and refresh an AMP page

TIMED OUT: /hello/

hi

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:409:7)

● AMP Usage › AMP dev mode › should detect changes and refresh a hybrid AMP page

TIMED OUT: /replaced it!/

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:502:9)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented May 3, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
buildDuration 15.7s 15.6s -74ms
buildDurationCached 6.2s 6.3s ⚠️ +31ms
nodeModulesSize 475 MB 475 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.572 3.556 -0.02
/ avg req/sec 699.81 703.12 +3.31
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.203 1.221 ⚠️ +0.02
/error-in-render avg req/sec 2078.88 2047.92 ⚠️ -30.96
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.7 kB 28.7 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.08 kB 3.08 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.71 kB 5.71 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.64 kB 2.64 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
buildDuration 17.7s 17.7s ⚠️ +45ms
buildDurationCached 6.3s 6.2s -54ms
nodeModulesSize 475 MB 475 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.568 3.531 -0.04
/ avg req/sec 700.61 707.99 +7.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.231 1.224 -0.01
/error-in-render avg req/sec 2030.05 2042.77 +12.72
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 29.1 kB 29.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 73 kB 73 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 3.08 kB 3.08 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.76 kB 5.76 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.76 kB 2.76 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.5 kB 16.5 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/enable-tests Change
index.html gzip 529 B 529 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 94b9a28

@timneutkens timneutkens merged commit fdc4ab8 into vercel:canary May 3, 2022
@timneutkens timneutkens deleted the fix/enable-tests branch May 3, 2022 13:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @huozhi