Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: place the charset meta tag at the top of the head #36561

Merged
merged 2 commits into from
May 22, 2022
Merged

fix: place the charset meta tag at the top of the head #36561

merged 2 commits into from
May 22, 2022

Conversation

await-ovo
Copy link
Contributor

@await-ovo await-ovo commented Apr 29, 2022 •
edited by ijjk
Loading

Fixes: #36432

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Apr 29, 2022 •
edited
Loading

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
buildDuration 15.8s 15.9s ⚠️ +86ms
buildDurationCached 6.5s 6.3s -185ms
nodeModulesSize 479 MB 479 MB ⚠️ +21 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.84 3.84 ✓
/ avg req/sec 651.04 651.03 ⚠️ -0.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.321 1.33 ⚠️ +0.01
/error-in-render avg req/sec 1892.9 1880.05 ⚠️ -12.85
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 29.1 kB 29.1 kB ⚠️ +1 B
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 72.8 kB 72.8 kB ⚠️ +1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.73 kB 5.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for main-HASH.js 
@@ -4014,7 +4014,7 @@
           }, [])
           .reduce(onlyReactElement, [])
           .reverse()
-          .concat(defaultHead(props.inAmpMode))
+          .concat(defaultHead(props.inAmpMode).reverse())
           .filter(unique())
           .reverse()
           .map(function(c, i) {
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a8cf4a5d1e521c01.js"
+      src="/_next/static/chunks/main-a47418fb2b240be8.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a8cf4a5d1e521c01.js"
+      src="/_next/static/chunks/main-a47418fb2b240be8.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a8cf4a5d1e521c01.js"
+      src="/_next/static/chunks/main-a47418fb2b240be8.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
buildDuration 18s 17.8s -198ms
buildDurationCached 6.3s 6.3s -48ms
nodeModulesSize 479 MB 479 MB ⚠️ +21 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.834 3.827 -0.01
/ avg req/sec 651.99 653.28 +1.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.323 1.338 ⚠️ +0.02
/error-in-render avg req/sec 1889.15 1867.99 ⚠️ -21.16
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.6 kB 29.6 kB ⚠️ +1 B
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 74 kB 74 kB ⚠️ +1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.82 kB 5.82 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.78 kB 2.78 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ✓
Client Build Manifests
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary await-ovo/next.js fix-meta-charset Change
index.html gzip 533 B 532 B -1 B
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB -1 B

Diffs

Diff for main-HASH.js 
@@ -4014,7 +4014,7 @@
           }, [])
           .reduce(onlyReactElement, [])
           .reverse()
-          .concat(defaultHead(props.inAmpMode))
+          .concat(defaultHead(props.inAmpMode).reverse())
           .filter(unique())
           .reverse()
           .map(function(c, i) {
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a8cf4a5d1e521c01.js"
+      src="/_next/static/chunks/main-a47418fb2b240be8.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a8cf4a5d1e521c01.js"
+      src="/_next/static/chunks/main-a47418fb2b240be8.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a8cf4a5d1e521c01.js"
+      src="/_next/static/chunks/main-a47418fb2b240be8.js"
       defer=""
     ></script>
     <script
Commit: 258bd9b

@await-ovo await-ovo force-pushed the fix-meta-charset branch 3 times, most recently from d76f90b to 130d5d9 Compare April 29, 2022 07:25
ijjk
ijjk approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit afbc511 into vercel:canary May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meta charset element still not at the top of <head>
2 participants
@await-ovo @ijjk