Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta charset element still not at the top of <head> #36432

Closed
1 task done
HandyHat opened this issue Apr 25, 2022 · 1 comment · Fixed by #36561
Closed
1 task done

meta charset element still not at the top of <head> #36432

HandyHat opened this issue Apr 25, 2022 · 1 comment · Fixed by #36561
Labels
bug Issue was opened via the bug report template.

Comments

@HandyHat
Copy link

HandyHat commented Apr 25, 2022 •
edited
Loading

Verify canary release

  • I verified that the issue exists in Next.js canary release

Provide environment information

Operating System:
      Platform: win32
      Arch: x64
      Version: Windows 10 Pro
    Binaries:
      Node: 16.14.2
      npm: N/A
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 12.1.6-canary.6
      react: 18.0.0
      react-dom: 18.0.0

What browser are you using? (if relevant)

Edge 100.0.1185.50

How are you deploying your application? (if relevant)

next export

Describe the Bug

Unfortunately #28119 has not fully fixed #26534 - as described as in this comment, <meta charset="utf-8"> is still only second from the top of <head>, rather than at the top, failing this hint

Expected Behavior

<meta charset="utf-8"> should be at the top of <head>

To Reproduce

Same as #26534

  • Add a font to _document.js
  • Run next build and next export
  • Observe that <meta charset="utf-8"> is still only second from the top of <head>, rather than at the top, with <meta name="viewport" content="width=device-width"> being first instead.
@HandyHat HandyHat added the bug Issue was opened via the bug report template. label Apr 25, 2022
@await-ovo await-ovo mentioned this issue Apr 29, 2022
Merged
10 tasks
@kodiakhq kodiakhq bot closed this as completed in #36561 May 22, 2022
kodiakhq bot pushed a commit that referenced this issue May 22, 2022
@await-ovo
fix: place the charset meta tag at the top of the head (#36561)
afbc511 
Fixes: #36432 



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: place the charset meta tag at the top of the head await-ovo/next.js
1 participant
@HandyHat