fix : example/with-noscript to use next@latest and react-dom #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the update to react ^16.0.0 react-dom import location has changed
timneutkens
approved these changes
Nov 4, 2017
timneutkens
pushed a commit
to timneutkens/next.js
that referenced
this pull request
Nov 5, 2017
…3237) * example with-noscript use next@latest * fix : example/with-noscript react-dom/server usage Since the update to react ^16.0.0 react-dom import location has changed
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2767
Since #3113 updated the react version to
^16.0.0the location of react-dom has changed.Now uses
next@latestinstead of^3.0.3