Skip to content

Commit

Permalink
fix : example/with-noscript to use next@latest and react-dom (#3237)
Browse files Browse the repository at this point in the history
* example with-noscript use next@latest

* fix : example/with-noscript react-dom/server usage

Since the update to react ^16.0.0 react-dom import location has changed
  • Loading branch information
andykenward authored and timneutkens committed Nov 4, 2017
1 parent c29ec6b commit 8bb31f0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion examples/with-noscript/components/Noscript.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react'
import ReactDOMServer from 'react-dom/lib/ReactDOMServer'
import ReactDOMServer from 'react-dom/server'

export default function Noscript (props) {
const staticMarkup = ReactDOMServer.renderToStaticMarkup(props.children)
Expand Down
2 changes: 1 addition & 1 deletion examples/with-noscript/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = {
webpack: (config, { dev }) => {
if (!dev) {
config.resolve.alias = {
'react-dom/server': require.resolve('react-dom/dist/react-dom-server.min.js')
'react-dom/server': require.resolve('react-dom/umd/react-dom-server.browser.production.min.js')
}
}
return config
Expand Down
2 changes: 1 addition & 1 deletion examples/with-noscript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"start": "next start"
},
"dependencies": {
"next": "^3.0.3",
"next": "latest",
"react": "^16.0.0",
"react-dom": "^16.0.0",
"react-lazyload": "^2.2.7"
Expand Down

0 comments on commit 8bb31f0

Please sign in to comment.