Do not mutate browser source map object #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression caused by vercel#2478
timneutkens
reviewed
Sep 4, 2017
| @@ -252,13 +252,14 @@ export default async function createCompiler (dir, { buildId, dev = false, quiet | |||
| let output = transpiled.code | |||
|
|
|||
| if (map) { | |||
| map.sources = map.sources.map((source) => source.replace(/\?entry/, '')) | |||
| delete map.sourcesContent | |||
| let nodeMap = Object.assign({}, map) | |||
There was a problem hiding this comment.
I guess this can be just const since you're not reassigning the variable.
|
I have just tested the fix (#2816 (comment)) and it works for me! @kpdecker Thank you! |
timneutkens
approved these changes
Sep 4, 2017
There was a problem hiding this comment.
Besides the const vs let comment everything's 💯 Thanks @kpdecker
|
@arunoda can you release this asap ❤️ Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression caused by #2478