Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit ES6 code for module source in emit file load #2478

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Emit ES6 code for module source in emit file load #2478

merged 1 commit into from
Jul 7, 2017

Conversation

kpdecker
Copy link
Contributor

@kpdecker kpdecker commented Jul 6, 2017

Previously the commonjs modules were being passed into webpack dependency layer, preventing tree shaking.

@kpdecker
Emit ES6 code for module source in emit file load
f4f4017 
Previously the commonjs modules were being passed into webpack dependency layer, preventing tree shaking.
@timneutkens timneutkens requested a review from arunoda July 6, 2017 16:41
@timneutkens
Copy link
Member

cc @arunoda

@arunoda
Copy link
Contributor

arunoda commented Jul 7, 2017

Oh my. This is a very good fix.
Thanks @kpdecker

@arunoda arunoda merged commit 3f50abc into vercel:v3-beta Jul 7, 2017
@arunoda arunoda removed their request for review July 7, 2017 04:18
@kpdecker
Copy link
Contributor Author

kpdecker commented Jul 8, 2017

As a heads up, this breaks the hot-self-accept-loader implementation due to changes in the backing module structure generated by webpack. Looking into a fix.

@arunoda
Copy link
Contributor

arunoda commented Jul 8, 2017

Okay. Then I'm gonna revert this for now.

arunoda added a commit that referenced this pull request Jul 8, 2017
@arunoda
Revert "Emit ES6 code for module source in emit file load (#2478)"
ebfa1bc 
This reverts commit 3f50abc.
@arunoda arunoda mentioned this pull request Jul 8, 2017
Merged
arunoda added a commit that referenced this pull request Jul 8, 2017
@arunoda
Revert "Emit ES6 code for module source in emit file load" (#2501)
4563f68 
* Revert "Update emotion example to use css instead of fragment (#2497)"

This reverts commit 5bd3a5f.

* Revert "Fix "Deploy to now" link (#2489)"

This reverts commit df1cd7e.

* Revert "Emit ES6 code for module source in emit file load (#2478)"

This reverts commit 3f50abc.
@kpdecker kpdecker mentioned this pull request Jul 9, 2017
Merged
@kpdecker kpdecker deleted the tree-shaking branch July 10, 2017 22:06
kpdecker added a commit to healthline/next.js that referenced this pull request Sep 3, 2017
@kpdecker
Do not mutate browser source map object
1d755f7 
Fixes regression caused by vercel#2478
kpdecker added a commit to healthline/next.js that referenced this pull request Sep 3, 2017
@kpdecker
Do not mutate browser source map object
260be86 
Fixes regression caused by vercel#2478
@kpdecker kpdecker mentioned this pull request Sep 3, 2017
Merged
kpdecker added a commit to healthline/next.js that referenced this pull request Sep 3, 2017
@kpdecker
Do not mutate browser source map object
3e98277 
Fixes regression caused by vercel#2478
timneutkens pushed a commit that referenced this pull request Sep 4, 2017
@kpdecker @timneutkens
Do not mutate browser source map object (#2900)
5c67fd6 
Fixes regression caused by #2478
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpdecker @timneutkens @arunoda