Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise ChatOps not to add go.mod & go.sum when /format runs #406

Merged
merged 2 commits into from
May 26, 2020
Merged

Revise ChatOps not to add go.mod & go.sum when /format runs #406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c4200
:green_heart: not to add go.mod & go.sum when /format runs
rinx May 26, 2020
0d36286
Update .github/workflows/chatops.yml
rinx May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/chatops.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ jobs:
sudo make prettier/install
# sudo make dockfmt/install

echo "Update license headers and format go codes/yaml/Dockerfile"
echo "Update license headers and format go codes/yaml"

make update/goimports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW start thinking do we need this update goimport?
as user should do the verification before creating PR.

make format/yaml
Expand All @@ -449,7 +449,8 @@ jobs:
git config --global user.email "ci@vdaas.org"

git add .
git commit --signoff -m ":robot: Update license headers and formatting go codes"
git reset go.mod go.sum
git commit --signoff -m ":robot: Update license headers / Format go codes and yaml files"

git remote set-url origin "https://${GITHUB_USER}:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git"

Expand Down