Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise ChatOps not to add go.mod & go.sum when /format runs #406

Merged
merged 2 commits into from
May 26, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 26, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented May 26, 2020

Score: 0.67

Best reviewed: commit by commit


Optimal code review plan

     💚 not to add go.mod & go.sum when /format runs

     Update .github/workflows/chatops.yml

Powered by Pull Assistant. Last update b1c4200 ... 0d36286. Read the comment docs.

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -435,7 +435,7 @@ jobs:
sudo make prettier/install
# sudo make dockfmt/install

echo "Update license headers and format go codes/yaml/Dockerfile"
echo "Update license headers and format go codes/yaml"

make update/goimports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW start thinking do we need this update goimport?
as user should do the verification before creating PR.

@kpango kpango merged commit aff3aab into master May 26, 2020
@kpango kpango deleted the ci/chatops/revise-git-add-on-format-command branch May 26, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants