Write err to stderr, exit 1 if err != "" #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
jszwedko
added a commit
that referenced
this pull request
Feb 4, 2017
Doing so limits the ability for users to have only some of their errors cause the application to terminate while allowing others to bubble up. This was originally an adjustment to #361 in #496 to fix #495, but, in hindsight, I believe that the better approach is to recommend the use of `RunAndExitOnError` for this use case (which is undeprecated here). Fixes #565 #594
jszwedko
added a commit
that referenced
this pull request
Mar 4, 2017
This was introduced in #496, but was discovered to be a regression in the behavior of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #475