Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure context lookups traverse lineage #495

Merged
merged 1 commit into from
Jul 24, 2016
Merged

Ensure context lookups traverse lineage #495

merged 1 commit into from
Jul 24, 2016

Conversation

meatballhat
Copy link
Member

Closes #487

@meatballhat
Copy link
Member Author

@moxar see any problems with this? 😸

@meatballhat meatballhat merged commit ee2e8aa into v2 Jul 24, 2016
@meatballhat meatballhat deleted the context-lookup-fix-487 branch July 24, 2016 15:17
@jszwedko
Copy link
Contributor

🎺

jszwedko added a commit that referenced this pull request Feb 4, 2017
@jszwedko
Do not exit if commands return non-ExitCoder errors
26c68e3 
Doing so limits the ability for users to have only some of their errors
cause the application to terminate while allowing others to bubble up.

This was originally an adjustment to #361 in #496 to fix #495, but, in
hindsight, I believe that the better approach is to recommend the use of
`RunAndExitOnError` for this use case (which is undeprecated here).

Fixes #565 #594
@jszwedko jszwedko mentioned this pull request Feb 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meatballhat @jszwedko