Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the email token tooltip more informative #1557

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Jan 3, 2023

Previously it said just "Token", but now it will provide more explicit instructions about copying and pasting the token received by email.

Resolves #1339

Previously it said just "Token", but now it will provide more explicit
instructions about copying and pasting the token received by email.

Resolves #1339
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.72 KB (+0.05% 🔺)
public/remark.css 8.12 KB (+0.02% 🔺)
public/last-comments.mjs 35.67 KB (0%)
public/last-comments.css 3.72 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 58.02% // Head: 58.02% // No change to project coverage 👍

Coverage data is based on head (baccc46) compared to base (1ab1ed8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   58.02%   58.02%           
=======================================
  Files         131      131           
  Lines        2911     2911           
  Branches      736      736           
=======================================
  Hits         1689     1689           
  Misses       1091     1091           
  Partials      131      131           
Impacted Files Coverage Δ
...pps/remark42/app/components/auth/auth.messsages.ts 100.00% <ø> (ø)
...ribe-by-email/comment-form__subscribe-by-email.tsx 90.59% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paskal paskal added this to the v1.11.3 milestone Jan 3, 2023
@umputun umputun requested a review from akellbl4 January 3, 2023 06:50
@paskal paskal merged commit 067a8bc into master Jan 3, 2023
@paskal paskal deleted the paskal/explicit_token_instructions branch January 3, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninformative tooltip for token input
2 participants