Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninformative tooltip for token input #1339

Closed
dkjb634 opened this issue Apr 27, 2022 · 5 comments · Fixed by #1557
Closed

Uninformative tooltip for token input #1339

dkjb634 opened this issue Apr 27, 2022 · 5 comments · Fixed by #1557

Comments

@dkjb634
Copy link

dkjb634 commented Apr 27, 2022

Hello,

It is not clear what a token I should enter in the following tooltip. Would be nice to write something like "Enter the token you received by email"

image

@markmonroy
Copy link

Was just coming here to post the same thing. The people who are going to comment on my blog are mostly elderly relatives. The more straightforward the registration process, the better.

By the same token (heh), it would be nice if the token were a short string of numbers instead of a big long hash, which may be difficult to copy on mobile. Or better yet, a link they can click/tap.

@umputun
Copy link
Owner

umputun commented Oct 9, 2022

The long token we sent by email is stateless, i.e. it includes all the info remark42 needs to realize all the auth related fields. Making it shorter won't work in this case.

Regarding email link - @paskal correct me if wrong, but following the link from email is troublesome because it will loose the state, and we won't be able to navigate to a proper place on UI side. For example, after the login it won't be able to pick the proper comment user answered to, and so on. Probably this can be resolved with some extra params passed and some UI changes, but this doesn't sound easy task to me. Another issue - we don't want to pass it by GET, and I don't know how universal is POST support in email clients.

@markmonroy
Copy link

Just following up on this. I feel I may have derailed the topic by bringing up links and shorter strings, but I would love to see @dkjb634 's initial suggestion of descriptive placeholder text, such as "Enter the token you received by email" instead of just "Token." Thanks!

@dkjb634
Copy link
Author

dkjb634 commented Dec 28, 2022

Completely agree with @markmonroy. It is very confusing. For the first time user feels like "What a Token? I want to add a comment. Where should I get that token, I have no idea."

@markmonroy
Copy link

I created a pull request updating the .tsx that defines the placeholder variable. Total amateur here...no idea how to get this change into my docker image, so fingers crossed that this modification works as I hope.

paskal added a commit that referenced this issue Jan 3, 2023
Previously it said just "Token", but now it will provide more explicit
instructions about copying and pasting the token received by email.

Resolves #1339
@paskal paskal added this to the v1.11.3 milestone Jan 3, 2023
paskal added a commit that referenced this issue Jan 3, 2023
Previously it said just "Token", but now it will provide more explicit
instructions about copying and pasting the token received by email.

Resolves #1339
itzomen pushed a commit to traleor/comments that referenced this issue Apr 16, 2023
Previously it said just "Token", but now it will provide more explicit
instructions about copying and pasting the token received by email.

Resolves umputun#1339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants