Update and fix custom condition documentation #6424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6361
Description
After having tried to create a custom condition for my extension, I ran into several issues following the documentation.
There were minor errors such as
true
being written asstrue
. But there were also some major issues, like things being imported which weren't used, extending the wrong classes and in general unclear ways to do stuff.I ran into an issue requiring many hours of debugging, reading documentation and trial-and-error, where the custom condition was extending the wrong class, leading to something like
args.host
beingundefined
, resulting in the entire extension never being permitted, never reaching the timeout.It also wasn't being shown how to make use of
match
, even though a condition config type was created to allow for this.Type of suggestion
Product & version (if relevant)
Umbraco 14