Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom extension conditions #6361

Closed
wants to merge 0 commits into from
Closed

Conversation

benstigsen
Copy link
Contributor

@benstigsen benstigsen commented Aug 19, 2024

Description

After having tried to create a custom condition for my extension, I ran into several issues following the documentation.

There were minor errors such as true being written as strue. But there were also some major issues, like things being imported which weren't used, extending the wrong classes and in general unclear ways to do stuff.

I ran into an issue requiring many hours of debugging, reading documentation and trial-and-error, where the custom condition was extending the wrong class, leading to something like args.host being undefined, resulting in the entire extension never being permitted, never reaching the timeout.

It also wasn't being shown how to make use of match, even though a condition config type was created to allow for this.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco 14

@benstigsen benstigsen changed the title Documentation update for adding Extension Conditions Update custom extension conditions Aug 19, 2024
@eshanrnh
Copy link
Contributor

Thanks for the PR, @benstigsen 🙌 We will review it as soon as we can. 💪

@sofietoft
Copy link
Contributor

Hi @benstigsen !

Apologies for the wait on this one.
I've run it through our developers, and everything seems to be checking out 💪

I see though, that there are some merge conflicts - most likely related to us restructuring the backoffice articles a couple of weeks back 😅
The article has been moved to here: https://github.com/umbraco/UmbracoDocs/blob/main/14/umbraco-cms/customizing/extending-overview/extension-types/condition.md

Are you up for making a new PR with the same changes? 🙈
I fully understand if you're not - just let me know, and I'll add the changes directly!

@benstigsen
Copy link
Contributor Author

@sofietoft the new pull-request can be found here: #6424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants