Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.jit.trace() fix #9363

Merged
merged 2 commits into from
Sep 10, 2022
Merged

torch.jit.trace() fix #9363

merged 2 commits into from
Sep 10, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 10, 2022

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancement of model export functionality and CI testing for YOLOv5 πŸš€.

πŸ“Š Key Changes

  • Added warmup and tracing to the Continuous Integration (CI) testing workflow for better simulation of real-world usage.
  • Included an extra image processing step in CI testing to ensure model functionality.
  • Updated the models/common.py file to prevent the outputting of loss values during export.

🎯 Purpose & Impact

  • 🎭 Improves testing robustness: The warm-up process and inclusion of the JIT trace ensure that CI testing resembles actual conditions more closely, leading to more reliable code.
  • 🧠 Models are easier to deploy: Suppressing loss output during model export makes the models cleaner for inference purposes, which is beneficial for users who want to deploy models easily into production environments.
  • πŸ›  Potentially reduces issues: These changes could lead to catching potential errors earlier, improving the overall quality of the YOLOv5 codebase.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher self-assigned this Sep 10, 2022
@glenn-jocher glenn-jocher linked an issue Sep 10, 2022 that may be closed by this pull request
2 tasks
@glenn-jocher glenn-jocher changed the title torch.jit.trace() fix torch.jit.trace() fix Sep 10, 2022
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6.2 is not torch.jit.trace-able
1 participant