-
-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoinstall TensorRT if missing #7537
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
59a3503
Autoinstall TensorRT if missing
glenn-jocher f0af29c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 95ebe90
Update export.py
glenn-jocher 20f5efe
Update export.py
glenn-jocher df7da68
Update export.py
glenn-jocher c5777b9
Update export.py
glenn-jocher 6a0173f
Merge branch 'master' into auto/tensorrt
glenn-jocher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @glenn-jocher , These wheels only works on Linux operating system and x86_64 CPU architecture with Python versions 3.6 to 3.9 and CUDA 11.x. See https://docs.nvidia.com/deeplearning/tensorrt/install-guide/index.html#installing-pip for more details. Many users use TensorRT on Windows, perhaps some explanations should be added here to prevent user annoyance when using it, such as #7009 (comment) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhiqwang good point! I can't programmatically check the CUDA version, but we can check OS before install. I'll make a PR. The Python version requirement is already met as YOLOv5 requires 3.7 (may also work with 3.6, but no longer supported).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhiqwang all done! PR #7549 is merged that implements OS checks prior to install. This should resolve most of the problem, and migration over time to CUDA 11 should resolve the rest of the issue. I guess Python 3.10 could be an edge case though.