Autoinstall TensorRT if missing #7537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May resolve #7464
zhiqwang
reviewed
Apr 23, 2022
| except Exception: | ||
| s = f"\n{prefix} tensorrt not found and is required by YOLOv5" | ||
| LOGGER.info(f"{s}, attempting auto-update...") | ||
| r = '-U nvidia-tensorrt --index-url https://pypi.ngc.nvidia.com' |
There was a problem hiding this comment.
FYI @glenn-jocher , These wheels only works on Linux operating system and x86_64 CPU architecture with Python versions 3.6 to 3.9 and CUDA 11.x. See https://docs.nvidia.com/deeplearning/tensorrt/install-guide/index.html#installing-pip for more details. Many users use TensorRT on Windows, perhaps some explanations should be added here to prevent user annoyance when using it, such as #7009 (comment) .
There was a problem hiding this comment.
@zhiqwang good point! I can't programmatically check the CUDA version, but we can check OS before install. I'll make a PR. The Python version requirement is already met as YOLOv5 requires 3.7 (may also work with 3.6, but no longer supported).
glenn-jocher
added a commit
that referenced
this pull request
Apr 23, 2022
May partially resolve concerns in #7537 (comment)
glenn-jocher
added a commit
that referenced
this pull request
Apr 23, 2022
May partially resolve concerns in #7537 (comment)
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* Autoinstall TensorRT if missing May resolve ultralytics#7464 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update export.py * Update export.py * Update export.py * Update export.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
May partially resolve concerns in ultralytics#7537 (comment)
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
* Autoinstall TensorRT if missing May resolve ultralytics#7464 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update export.py * Update export.py * Update export.py * Update export.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
May partially resolve concerns in ultralytics#7537 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May help resolve #7464
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced error handling and auto-update for TensorRT in YOLOv5 export script.
📊 Key Changes
🎯 Purpose & Impact