Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS unused variable fix #7161

Merged
merged 2 commits into from
Mar 26, 2022
Merged

NMS unused variable fix #7161

merged 2 commits into from
Mar 26, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Mar 26, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refinement of Non-Maximum Suppression (NMS) functionality in YOLOv5.

πŸ“Š Key Changes

  • Improved the NMS documentation string to more accurately describe its purpose.
  • Removed the minimum dimension constraint (min_wh) check for bounding boxes.
  • Cleaned up code by eliminating unused warning timer logic for NMS processing time.

🎯 Purpose & Impact

  • Clarifies the description of NMS to help users understand its function (rejecting overlapping bounding boxes).
  • Simplifies the NMS function by not enforcing a minimum box width and height, potentially reducing false negatives (legitimate detections being discarded).
  • Streamlines the time limit warning in NMS, making the log message consistent and removing the condition that obscured repetitive warnings. This cleans up the warnings and maintains user awareness when the time limit is exceeded, without spamming the log.

@glenn-jocher glenn-jocher merged commit 3373aab into master Mar 26, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch March 26, 2022 15:52
KSGulin pushed a commit to neuralmagic/yolov5 that referenced this pull request Apr 12, 2022
* NMS unused variable fix

* Update general.py
KSGulin pushed a commit to neuralmagic/yolov5 that referenced this pull request Apr 14, 2022
* NMS unused variable fix

* Update general.py
KSGulin added a commit to neuralmagic/yolov5 that referenced this pull request Apr 15, 2022
* pip installable auto package

* Adjust NMS time limit warning to batch size (ultralytics#7156)

* NMS unused variable fix (ultralytics#7161)

* Fix --resume keyword and recipe loading (#33)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* NMS unused variable fix

* Update general.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant