Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust NMS time limit warning to batch size #7156

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Adjust NMS time limit warning to batch size #7156

merged 1 commit into from
Mar 26, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Mar 26, 2022 •
edited by UltralyticsAssistant
Loading

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced time management in non-maximum suppression (NMS) algorithm.

📊 Key Changes

  • Introduced a variable bs to represent the batch size.
  • Adjusted the time_limit for NMS processing to scale with the batch size.
  • Added a conditional warning to only log once when the time limit is exceeded.

🎯 Purpose & Impact

  • The dynamic time limit improves efficiency by adapting to different batch sizes, preventing longer waits for small batches.
  • The change ensures that performance issues are logged appropriately without excessive warnings, which is crucial for user awareness without causing alarm fatigue.
  • Overall, these tweaks aim to optimize the NMS stage of object detection, impacting the end-user by potentially improving the speed and reliability of results from YOLOv5's object detection tasks. 🚀🕒🔍

@glenn-jocher glenn-jocher self-assigned this Mar 26, 2022
@glenn-jocher glenn-jocher merged commit 26bfd44 into master Mar 26, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch March 26, 2022 10:45
KSGulin pushed a commit to neuralmagic/yolov5 that referenced this pull request Apr 12, 2022
@glenn-jocher @KSGulin
Adjust NMS time limit warning to batch size (ultralytics#7156)
87402a0
KSGulin pushed a commit to neuralmagic/yolov5 that referenced this pull request Apr 14, 2022
@glenn-jocher @KSGulin
Adjust NMS time limit warning to batch size (ultralytics#7156)
789f6c1
KSGulin added a commit to neuralmagic/yolov5 that referenced this pull request Apr 15, 2022
@KSGulin
Catch up main -> release/0.12 (#35)
c2fe8bd 
* pip installable auto package

* Adjust NMS time limit warning to batch size (ultralytics#7156)

* NMS unused variable fix (ultralytics#7161)

* Fix --resume keyword and recipe loading (#33)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@glenn-jocher
Adjust NMS time limit warning to batch size (ultralytics#7156)
5c50504
@Hojland Hojland mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glenn-jocher glenn-jocher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glenn-jocher