precommit: isort #5493
Merged
precommit: isort #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@Borda awesome, I didn't know about isort! I looked at the results. Could we configure isort to create the default behavior shown on their README? Current PR is turning all multi-line imports into one-per-line, but README shows from file import (p1,p2,p3 etc.) utilizing full line width. Current behavior (this PR)
Desired behavior (https://github.com/PyCQA/isort README)
|
Borda
commented
Nov 4, 2021
| @@ -43,3 +43,11 @@ ignore = | |||
| F403 | |||
| E302 | |||
| F541 | |||
|
|
|||
|
|
|||
| [isort] | |||
There was a problem hiding this comment.
@glenn-jocher here is the configuration :]
feel free to edit it how you wish and let the bot update the PR
There was a problem hiding this comment.
@Borda awesome!! Thanks I'll experiment with it.
|
@Borda PR is merged. I reverted most of the isort settings back to default values except for line length 120. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* precommit: isort * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update isort config * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update name Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use Isort as default import formatting
Partial alternative to #4983
This PR defines Isort as pre-commit hook and lets the bot fix it... rabbit
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
This PR brings codebase improvements mainly by enlisting third-party tools for code clean-up and organizing imports.
📊 Key Changes
isorttool in.pre-commit-config.yamlto automatically sort the imports.detect.py,export.py,hubconf.py, and others to be more organized and readable based on theisortstandard.isortconfiguration insetup.cfg, specifying a line length of 120 characters and a single-line output for multiple imports.🎯 Purpose & Impact
isort🔄 ensures that the imports are consistently formatted, which makes the code easier to read and maintain.