Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use formatting Isort/YAPF/Black #4983

Closed
Borda opened this issue Sep 28, 2021 · 3 comments · Fixed by #5494
Closed

use formatting Isort/YAPF/Black #4983

Borda opened this issue Sep 28, 2021 · 3 comments · Fixed by #5494
Labels
enhancement New feature or request Stale

Comments

@Borda
Copy link
Contributor

Borda commented Sep 28, 2021

🚀 Feature

Lets standartize the code formating:

  • Isort for import cleaning
  • YAPF for custom code formating
  • Black is just one strong one

Motivation

Improve the code readability

Pitch

Alternatives

could be integrated with pre-commit, see #4982

Additional context

Thoughts on Why Code Formatting is even more important for Open-Source

@Borda Borda added the enhancement New feature or request label Sep 28, 2021
@glenn-jocher
Copy link
Member

@Borda yes I think this is a good idea!

I've been manually sorting imports alphabetically (when I have time) since I couldn't find a formatter to do this.

I looked at black previously but decided against it as it was a bit too aggressive. Maybe Flake8 or YAPF would be a better start.

Nice article!

@Borda
Copy link
Contributor Author

Borda commented Sep 29, 2021

I've been manually sorting imports alphabetically (when I have time) since I couldn't find a formatter to do this.

Isort does it
https://github.com/Borda/BIRL/blob/cae694f52434e74386a9f1fd2007a218e3a3d670/setup.cfg#L57-L67

I looked at black previously but decided against it as it was a bit too aggressive. Maybe Flake8 or YAPF would be a better start.

yes, you can have look at
https://github.com/Borda/BIRL/blob/cae694f52434e74386a9f1fd2007a218e3a3d670/setup.cfg#L45-L54

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2021

👋 Hello, this issue has been automatically marked as stale because it has not had recent activity. Please note it will be closed if no further activity occurs.

Access additional YOLOv5 🚀 resources:

Access additional Ultralytics ⚡ resources:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐!

@github-actions github-actions bot added the Stale label Oct 30, 2021
This was referenced Nov 3, 2021
@github-actions github-actions bot closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants