-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GW-RT global_control.nml modifications #2425
Open
dpsarmie
wants to merge
20
commits into
ufs-community:develop
Choose a base branch
from
dpsarmie:fix/updateNMLforGW
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5bf503b
Add namelist options to prepare for RT-GW merge
dpsarmie 1650d9c
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie 5da99f8
Update and resolve conflicts
dpsarmie c4568a6
Add changes to cpld_control_sfs RT
dpsarmie 41b1d6d
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie c643496
Fix bug in default_vars.sh
dpsarmie aa3719e
Fix rewritten atm vars
dpsarmie 7eeba49
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie 4655fd7
Remove debug statements
dpsarmie b351192
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie a5b6e2d
pdlib test changes
dpsarmie 92cd56d
Standard setting method for RTs
dpsarmie 77b5bdb
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie 5943d72
Add timing checks; Rework default_vars
dpsarmie c783631
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie 2c76c4e
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie d6b770e
Update cpld_control_sfs
dpsarmie ca95832
atm_ds2s_docn_dice dependency fix
dpsarmie 255ac07
Merge branch 'ufs-community:develop' into fix/updateNMLforGW
dpsarmie 796a0d0
Fixes rt.conf
dpsarmie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think SKEB, SPPT, SHUM are missing default values (like EPBL).
If I understand, are you wanting these to default to what is being used in GEFS prototype? Maybe @pjpegion can confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we default to what's in global workflow (?):
https://github.com/NOAA-EMC/global-workflow/blob/develop/parm/config/gefs/config.efcs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm was setting defaults based off of GW. There are some missing entries that are not here that will be added.
I'm scheduling a meeting soon with GW to talk about some discrepancies in the RT and GW namelist and what they would prefer.
The missing defaults are here on a branch I created for the GW PR: https://github.com/dpsarmie/global-workflow/blob/feature/GW-RT_GlobalNML/global_control.nml.IN#L393