ufs-community · dpsarmie · Aug 30, 2024 · Sep 3, 2024 · Sep 13, 2024 · Sep 16, 2024
diff --git a/tests/default_vars.sh b/tests/default_vars.sh
diff --git a/tests/parm/global_control.nml.IN b/tests/parm/global_control.nml.IN
diff --git a/tests/rt.conf b/tests/rt.conf
@@ -296,11 +296,10 @@ COMPILE | datm_cdeps_lm4 | intel | -DAPP=LND-LM4 | + hera orion gaea | fv3 |
 RUN     | datm_cdeps_lm4_gswp3                          | + hera orion gaea  | baseline |
 RUN     | datm_cdeps_lm4_gswp3_rst                      | + hera orion gaea  |          | datm_cdeps_lm4_gswp3
 
-
 ### AMIP+ tests ###
 COMPILE | atm_ds2s_docn_pcice | intel | -DAPP=ATM_DS2S-PCICE -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 | | fv3 |
 RUN | atm_ds2s_docn_pcice                               | - noaacloud                          | baseline |
-COMPILE | atm_ds2s_docn_dice | intel | -DAPP=ATM_DS2S  -DCCPP_SUITES=FV3_GFS_v17_coupled_p8    | - wcoss2 acorn  | fv3 |
+COMPILE | atm_ds2s_docn_dice | intel | -DAPP=ATM_DS2S  -DCCPP_SUITES=FV3_GFS_v17_coupled_p8_ugwpv1 | - wcoss2 acorn  | fv3 |
 RUN | atm_ds2s_docn_dice                                | - noaacloud wcoss2 acorn             | baseline | cpld_control_nowave_noaero_p8
 
 ### ATM-LND tests ###

diff --git a/tests/run_test.sh b/tests/run_test.sh
@@ -339,6 +339,22 @@ if [[ ${FIRE_BEHAVIOR} = 'true' ]]; then
   atparse < "${PATHRT}/parm/${FIRE_NML:-namelist.fire.IN}" > namelist.fire
 fi
 
+#Namelists generated and variable definitions are finalized
+#Sanity check for timesteps on ATM/OCN/ICE
+if [[ -n "${DT_CICE+x}" ]]; then
+  if [[ ${DT_ATMOS} -ne ${DT_CICE} ]]; then
+    echo "Atmosphere timestep (DT_ATMOS) should be equal to CICE timestep (DT_CICE). Exiting"
+    exit 1
+  fi
+fi
+if [[ -n "${coupling_interval_slow_sec+x}" && -n "${coupling_interval_fast_sec+x}" ]]; then
+  if [[ $(( coupling_interval_slow_sec % coupling_interval_fast_sec)) -ne 0 ]]; then
+    echo "The slow coupling timestep (coupling_interval_slow_sec) should be divisible by"
+    echo "the fast coupling timestep (coupling_interval_fast_sec). Exiting"
+    exit 1
+  fi
+fi
+
 TPN=$(( TPN / THRD ))
 if (( TASKS < TPN )); then
   TPN=${TASKS}

diff --git a/tests/tests/atm_ds2s_docn_dice b/tests/tests/atm_ds2s_docn_dice
@@ -64,7 +64,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    RESTART/20210323.060000.sfc_data.tile6.nc \
                    RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc"
 
+export DT_ATMOS=720
+
 export_fv3
+export_ugwpv1
 export_cpl
 
 #Component settings
@@ -112,7 +115,14 @@ export RESTART_N=12
 export RESTART_INTERVAL="${RESTART_N} -1"
 export OUTPUT_FH='0 21 24'
 
-export CCPP_SUITE=FV3_GFS_v17_coupled_p8
+export K_SPLIT=4
+export N_SPLIT=5
+
+# HR4 GFSv17 GWD update
+export DO_GWD_OPT_PSL=.true.
+export DO_GSL_DRAG_SS=.false.
+
+export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 export DIAG_TABLE=diag_table_gfsv16
 export FIELD_TABLE=field_table_thompson_noaero_tke
 export INPUT_NML=global_control.nml.IN

diff --git a/tests/tests/control_p8_mynn b/tests/tests/control_p8_mynn
@@ -93,6 +93,12 @@ export NSTF_NAME=2,1,0,0,0
 export LHEATSTRG=.false.
 export LSEASPRAY=.true.
 
+export FAST_TAU_W_SEC=0.2
+export RF_CUTOFF=10.
+export ISATMEDMF=1
+export LRADAR=.false.
+export LTAEROSOL=.false.
+
 # UGWP1
 export GWD_OPT=2
 export DO_UGWP_V1=.false.

diff --git a/tests/tests/cpld_2threads_p8 b/tests/tests/cpld_2threads_p8
@@ -57,9 +57,10 @@ export LIST_FILES="sfcf024.tile1.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
 
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -95,8 +96,6 @@ if [[ $MACHINE_ID = derecho ]]; then
   TPN=96
 fi
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5
 

diff --git a/tests/tests/cpld_bmark_p8 b/tests/tests/cpld_bmark_p8
@@ -50,10 +50,11 @@ export LIST_FILES="sfcf006.nc \
                    RESTART/ufs.cpld.cpl.r.2013-04-01-21600.nc \
                    20130401.060000.out_pnt.ww3 \
                    20130401.060000.out_grd.ww3 "
+export ATMRES=C384
 
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export SYEAR=2013
@@ -89,7 +90,6 @@ export ice_omp_num_threads=$ICE_thrds_cpl_bmrk
 export wav_omp_num_threads=$WAV_thrds_cpl_bmrk
 
 # atm/ocn/ice resolution
-export ATMRES=C384
 export NPX=385
 export NPY=385
 export IMO=1536

diff --git a/tests/tests/cpld_bmark_p8_35d b/tests/tests/cpld_bmark_p8_35d
@@ -7,6 +7,8 @@ export CNTL_DIR=cpld_bmark_p8
 
 export LIST_FILES=""
 
+export ATMRES=C384
+
 export_fv3
 export_cpl
 
@@ -43,7 +45,6 @@ export ice_omp_num_threads=$ICE_thrds_cpl_bmrk
 export wav_omp_num_threads=$WAV_thrds_cpl_bmrk
 
 # atm/ocn/ice resolution
-export ATMRES=C384
 export NPX=385
 export NPY=385
 export IMO=1536

diff --git a/tests/tests/cpld_control_c192_p8 b/tests/tests/cpld_control_c192_p8
@@ -56,9 +56,13 @@ export LIST_FILES="sfcf030.tile1.nc \
                    20210323.120000.out_grd.ww3 \
                    20210323.120000.out_pnt.ww3 "
 
+export ATMRES=C192
 export_fv3
+export_ugwpv1
 export_cpl
 
+export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
+
 export DAYS=1.25
 export FHMAX=30
 export RESTART_N=15
@@ -82,7 +86,6 @@ export chm_omp_num_threads=$atm_omp_num_threads
 export med_omp_num_threads=$atm_omp_num_threads
 
 # atm/ocn/ice resolution
-export ATMRES=C192
 export NPX=193
 export NPY=193
 export IMO=768
@@ -134,8 +137,6 @@ export FNVMXC="'C192.vegetation_greenness.tileX.nc'"
 export FNSLPC="'C192.slope_type.tileX.nc'"
 export FNABSC="'C192.maximum_snow_albedo.tileX.nc'"
 
-export CDMBWD=${CDMBWD_c192}
-
 export FV3_RUN=cpld_control_run.IN
 
 if [[ $MACHINE_ID = derecho ]]; then

diff --git a/tests/tests/cpld_control_c48 b/tests/tests/cpld_control_c48
@@ -52,11 +52,11 @@ export LIST_FILES="sfcf024.tile1.nc \
                    RESTART/20210323.060000.MOM.res.nc \
                    RESTART/iced.2021-03-23-21600.nc \
                    RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc"
+export ATMRES=C48
 
 export_fv3
-export_cpl
 export_ugwpv1
-
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -74,7 +74,6 @@ OCN_tasks=$OCN_tasks_cpl_c48
 ICE_tasks=$ICE_tasks_cpl_c48
 
 # atm/ocn/ice resolution
-export ATMRES=C48
 export NPX=49
 export NPY=49
 export IMO=192

diff --git a/tests/tests/cpld_control_ciceC_p8 b/tests/tests/cpld_control_ciceC_p8
@@ -68,10 +68,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
-
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -86,8 +86,6 @@ export CICE_GRIDICE=C
 
 export FV3_RUN=cpld_control_run.IN
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5
 

diff --git a/tests/tests/cpld_control_gfsv17 b/tests/tests/cpld_control_gfsv17
@@ -71,8 +71,8 @@ export LIST_FILES="sfcf021.tile1.nc \
                    20210323.060000.out_grd.ww3 "
 
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 
 export CPLCHM=.false.
 export DNATS=0

diff --git a/tests/tests/cpld_control_gfsv17_iau b/tests/tests/cpld_control_gfsv17_iau
@@ -52,8 +52,8 @@ export LIST_FILES="sfcf024.nc \
                    20210323.120000.out_grd.ww3 "
 
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 
 export CPLCHM=.false.
 export DNATS=0

diff --git a/tests/tests/cpld_control_noaero_p8 b/tests/tests/cpld_control_noaero_p8
@@ -69,8 +69,8 @@ export LIST_FILES="sfcf021.tile1.nc \
                    20210323.060000.out_grd.ww3 "
 
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12

diff --git a/tests/tests/cpld_control_nowave_noaero_p8 b/tests/tests/cpld_control_nowave_noaero_p8
@@ -67,10 +67,11 @@ export LIST_FILES="sfcf021.tile1.nc \
                    RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc"
 
 #TODO: add comparison of CA restart files?
+export DT_ATMOS=720
 
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -107,7 +108,7 @@ export UFS_CONFIGURE=ufs.configure.s2s_esmf.IN
 
 export FV3_RUN=cpld_control_run.IN
 
-export K_SPLIT=2
+export K_SPLIT=4
 export N_SPLIT=5
 
 # HR4 GFSv17 GWD update

diff --git a/tests/tests/cpld_control_p8 b/tests/tests/cpld_control_p8
@@ -68,10 +68,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
-
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -88,8 +88,6 @@ if [[ $MACHINE_ID = derecho ]]; then
   TPN=96
 fi
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5
 

diff --git a/tests/tests/cpld_control_p8.v2.sfc b/tests/tests/cpld_control_p8.v2.sfc
@@ -69,9 +69,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
 
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -89,8 +90,6 @@ if [[ $MACHINE_ID = derecho ]]; then
   TPN=96
 fi
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5
 

diff --git a/tests/tests/cpld_control_p8_faster b/tests/tests/cpld_control_p8_faster
@@ -69,9 +69,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
 
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -84,8 +85,6 @@ export eps_imesh=2.5e-1
 
 export FV3_RUN=cpld_control_run.IN
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5
 

diff --git a/tests/tests/cpld_control_p8_mixedmode b/tests/tests/cpld_control_p8_mixedmode
@@ -69,9 +69,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
 
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -84,8 +85,6 @@ export eps_imesh=2.5e-1
 
 export FV3_RUN=cpld_control_run.IN
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5
 

diff --git a/tests/tests/cpld_control_pdlib_p8 b/tests/tests/cpld_control_pdlib_p8
@@ -68,9 +68,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
 
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export RESTART_N=12
@@ -104,12 +105,10 @@ export UFS_CONFIGURE=ufs.configure.s2sw_fast_esmf.IN
 
 export FV3_RUN=cpld_control_run.IN
 
-if [[ $MACHINE_ID = hera ]] && [[ $RT_COMPILER = gnu ]]; then
-  WLCLK=40
+if [[ $RT_COMPILER = gnu ]]; then
+  WLCLK=50
 fi
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5
 

diff --git a/tests/tests/cpld_control_qr_p8 b/tests/tests/cpld_control_qr_p8
@@ -68,10 +68,10 @@ export LIST_FILES="sfcf021.tile1.nc \
                    RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc \
                    20210323.060000.out_pnt.ww3 \
                    20210323.060000.out_grd.ww3 "
-
+export DT_ATMOS=720
 export_fv3
-export_cpl
 export_ugwpv1
+export_cpl
 export CCPP_SUITE=FV3_GFS_v17_coupled_p8_ugwpv1
 
 export QUILTING_RESTART=.true.
@@ -85,8 +85,6 @@ export eps_imesh=2.5e-1
 
 export FV3_RUN=cpld_control_run.IN
 
-export DT_INNER=720
-export DT_ATMOS=720
 export K_SPLIT=4
 export N_SPLIT=5