-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GW-RT global_control.nml modifications #2425
base: develop
Are you sure you want to change the base?
Conversation
This adds new options to the namelist that are used and dynamic in the global workflow. This is to prepare the RT namelist for the RT-GW bridge PR.
This commit changes a couple of the parameters in cpld_control_sfs to bring it in line with the Global Workflow parameter values.
This commit addresses the issue in default_vars.sh where ATMRES is reset in the export_cpl() call to C96. Default values will now only be set if the resolutions have not been previously set.
@dpsarmie I also hit a problem with DT_ATMOS. For gfsv17 tests for example:
Maybe export_cpl should not touch DT_ATMOS either. It may also be better in these tests to call export_fv3, then export_ugwpv1, then export_cpl so atmosphere is configured properly before setting other components |
Thanks @NickSzapiro-NOAA for bringing that up. I'll have to do some more testing to see what makes sense. I think the simplest solution would be to make the atm only and cpld default DT_ATMOS the same, but I want to make sure that the runtime isn't greatly affected for the atm only cases. |
I think it is better if DT_ATMOS is thought of as input to export_cpl (and not modified in export_cpl). The issue I'm focusing on is (coupling) timesteps for gfsv17 test, where ufs.configure is the same before and after 2363:
But, dt_atmos in model_configure is 360s in current develop vs 720s before 2363. Was it intended for 2363 to reduce timestep for this test? Either way, now FV3<-->CMEPS no longer couple every ATM timestep, ATM timestep is different than ICE timestep,... I'm not sure this is intentional and may need hot fix if not intended. |
Ok I see what you mean. #2363 was intended to change the timesteps to have the more optimized set of parameter values to allow for more stability at longer timesteps: NOAA-EMC/global-workflow#2574 I'm going to move forward with your idea of having DT_ATMOS set in That should allow DT_CICE and coupling_interval_fast_sec to be set correctly when the other export calls are run from within Line 1302 will also be removed in default_vars.sh since DT_INNER will have been set by then. Let me know if that logic makes sense. That should resolve the issues of not having the timing in sync between the models, correct? |
That makes sense to me. Maybe can ask Denise to review solution too |
Latest changes do the following: To fix the timing issue it CMEPS, default_vars.sh has been reworked. If you export DT_ATMOS and/or ATMRES before the export_fv3 (and other export functions), then all dependent variables will be auto-populated. If these variables are not set, then defaults will be set. You can still manually set these parameters after the function calls but you need to make sure that all variables that depend on DT_ATMOS and ATMRES are also set unless you intended to do so otherwise. Either way, the timing with CMEPS should be functioning as intended. |
@dpsarmie In the PR description, can you add how the logic/flow in default_vars works and should be used? |
@NickSzapiro-NOAA I added a snippet to the description on how it should be used. I'm actually currently working on a more detailed document for how to use the new features, so let me know if anything is unclear or if anything else should be added to the description for the PR. |
@dpsarmie I'm getting confused about where the B4B differences are arising. It seems you're combining what is a bug-fix (the issue w/ dt_atmos), with updates of various namelist settings to match GW. Both of these tasks create non-B4B changes, is that right? Should we really be combining a bug fix w/ what is actually a new feature (consistency w/ G-W)? |
@DeniseWorthen Yes, the changes to the namelist and the associated changes to default_vars (just adding variables) were changes that were still B4B comparable. I've opened individual issues for documentation purposes since it is getting a bit complex. I'll add something to the description to try and detail the changes and which issue was addressed by which change in the code. There won't be anything else added to this PR. |
@dpsarmie Thanks for adding the information. Did either Variable values that were hard-coded in global_control.nml.IN were replaced with an @ tag and the values were moved to default_vars.sh. change baselines? I'm confused because the next change is described with This will add additional baseline changes. (emphasis added). If either of the first two items changed baselines, then I believe it is poor CM practice to combine issues which both change a set of tests. Rolling them together makes it much harder to un-roll/debug in the future, if required. |
@DeniseWorthen Yes, the cpld_control_sfs test underwent two baseline changes. The GW settings change (second item under Description) and the DT_ATMOS fix (third item) had two distinct changes in that baseline. I can untangle those easily and create an independent PR so there's only one baseline change per PR. |
Remove changes that have been moved to ufs-community#2475
export ISEED_SKEB=0 | ||
export SKEB_TAU=21600, | ||
export SKEB_LSCALE=500000, | ||
export SKEBNORM=1, | ||
export SKEB_NPASS=30, | ||
export SKEB_VDOF=5, | ||
export ISEED_SHUM=1, | ||
export SHUM_TAU=21600, | ||
export SHUM_LSCALE=500000, | ||
export ISEED_SPPT=20210325000103,20210325000104,20210325000105,20210325000106,20210325000107 | ||
export SPPT_TAU=2.16E4,2.592E5,2.592E6,7.776E6,3.1536E7 | ||
export SPPT_LSCALE=500.E3,1000.E3,2000.E3,2000.E3,2000.E3 | ||
export SPPT_LOGIT=.true., | ||
export SPPT_SFCLIMIT=.true., | ||
export USE_ZMTNBLCK=.true. | ||
export PBL_TAPER=0,0,0,0.125,0.25,0.5,0.75 | ||
export OCNSPPT=0.8,0.4,0.2,0.08,0.04 | ||
export OCNSPPT_LSCALE=500.E3,1000.E3,2000.E3,2000.E3,2000.E3 | ||
export OCNSPPT_TAU=2.16E4,2.592E5,2.592E6,7.776E6,3.1536E7 | ||
export ISEED_OCNSPPT=20210325000108,20210325000109,20210325000110,20210325000111,20210325000112 | ||
export EPBL=0.8,0.4,0.2,0.08,0.04 | ||
export EPBL_LSCALE=500.E3,1000.E3,2000.E3,2000.E3,2000.E3 | ||
export EPBL_TAU=2.16E4,2.592E5,2.592E6,7.776E6,3.1536E7 | ||
export ISEED_EPBL=20210325000113,20210325000114,20210325000115,20210325000116,20210325000117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think SKEB, SPPT, SHUM are missing default values (like EPBL).
If I understand, are you wanting these to default to what is being used in GEFS prototype? Maybe @pjpegion can confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we default to what's in global workflow (?):
https://github.com/NOAA-EMC/global-workflow/blob/develop/parm/config/gefs/config.efcs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm was setting defaults based off of GW. There are some missing entries that are not here that will be added.
I'm scheduling a meeting soon with GW to talk about some discrepancies in the RT and GW namelist and what they would prefer.
The missing defaults are here on a branch I created for the GW PR: https://github.com/dpsarmie/global-workflow/blob/feature/GW-RT_GlobalNML/global_control.nml.IN#L393
tests/tests/atm_ds2s_docn_dice
Outdated
# UGWP1 | ||
export GWD_OPT=2 | ||
export KNOB_UGWP_NSLOPE=1 | ||
export DO_GSL_DRAG_LS_BL=.true. | ||
export DO_GSL_DRAG_SS=.true. | ||
export DO_UGWP_V1_OROG_ONLY=.false. | ||
export DO_UGWP_V0_NST_ONLY=.false. | ||
export LDIAG_UGWP=.false. | ||
|
||
export DO_GSL_DRAG_TOFD=.false. | ||
export CDMBWD=${CDMBWD_c96} | ||
|
||
# UGWD | ||
export DO_UGWP_V0=.true. | ||
export DO_UGWP_V1=.false. | ||
export DO_GSL_DRAG_LS_BL=.false. | ||
export KNOB_UGWP_VERSION=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this different than the cpld_control_nowave_noaero_p8 test it depends on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atm_ds2s_docn_dice settings should now reflect the cpld_control_nowave_noaero_p8 settings.
export DT_INNER=${DT_ATMOS} | ||
|
||
export default_dt_atmos=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is DT_INNER always equal to DT_ATMOS?
Why is the value of default_dt_atmos changing here? Is it used somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the test is running the ugwpv1, then yes DT_INNER will be set to DT_ATMOS. If we set DT_INNER to half of DT_ATMOS (which is what GW is doing), then a handful of tests run over the allotted wall clock time. I did this to keep the RTs under the wall clock, but I did test the RTs using the GW parameters that were discussed here: #2363 to make sure that they were stable on our end.
default_dt_atmos changes here to make sure that it does not change in export_cpl(). I'm allowing export_cpl() to change DT_ATMOS for now to keep functionality with ugwpv0. When the time comes to deprecate version 0, then L1403 - 1407 should be removed.
This was resolved by adding a default_dt_atmos variable. If DT_ATMOS is not defined before the The new ordering of the function calls should be All other model configuration combinations should also work. ATM only (export_fv3), coupled using gwpv0 (export_fv3, export_cpl), ATM gwpv1 only, (export_fv3, export_ugwpv1), and coupled gwpv1 (export_fv3, export_ugwpv1, export_cpl) are all working as intended. |
Commit Queue Requirements:
There is now an option to allow default_vars.sh to set variables that are dependent on
DT_ATMOS
andATMRES
. If you wish to use a non-default value for either variable and have the script set all dependent variables automatically (ex. DT_INNER, CDMBGWD, namsfc filenames, etc.), thenDT_ATMOS
andATMRES
must be defined before calling the export functions.If the user does not define the variable, then the defaults of C96 (ATMRES) and 1800 (DT_ATMOS for atm only) or 720 (DT_ATMOS for cpld cases) will be set.
Example:
Your RT uses C48 resolution and you want a timestep of 720:
In your test configuration:
This will now be able to use the user defined timestep and resolution to populate the other variables needed to run this case. As always, the order of the export function calls should go export_fv3, export_ugwpv1, then export_cpl. You can remove export function calls as needed for your particular case.
You are still able to use the old methodology of defining all variables manually. This feature just allows users to streamline that process.
Non-standard RT configurations
It should be noted that many of the RTs have changes to variables from what is being set in default_vars.sh (mainly N_SPLIT, K_SPLIT, and DT_ATMOS). This was done because the runtime of the default settings was too long for the regression test suite. The RTs are made to provide a fidelity check on future UFS updates, so these checks are still valid even if some of the variables that affect runtime have been changed.
The runs using the default values were checked for stability and passed; however, there are no plans to regularly check the RTs using the default values on a regular basis.
Description:
This PR will modify the global_control.nml to add variables that are present in the Global Workflow scripts but not currently present in the RTs. Some variables will also be changed from constants to variable placeholders. This will allow Global Workflow to use the global_control.nml as a template for their operations.
Variable values that were hard-coded in global_control.nml.IN were replaced with an @ tag and the values were moved to default_vars.sh.
This PR is now also going to include a fix for #2443. This will add baseline changes that are unrelated to the initial global_control.nml modifications or the sfs configuration fix.
Default values for DT_ATMOS and ATMRES are now being set as intended. If the user defines either of these variables before the export_ function calls, then the appropriate dependent variables will be auto-configured. This removes the need to redefine these variables in the test configs.
This PR now includes a feature mentioned in #2470. The checks have been added to run_test.sh.
Changes in run_test.sh now have checks for the fast and slow coupling frequencies and a check on the CICE to ATM timesteps.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: