Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FV3] Add a new RT for the SDF FV3_WoFS_v0 #1460

Merged
merged 17 commits into from
Nov 1, 2022

Conversation

ChunxiZhang-NOAA
Copy link
Contributor

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Oct 18, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR is created (1) in favor of PR#1158, which adds a new suite definition file (FV3_WoFS_v0) to FV3 to use the NSSL cloud microphysics scheme with Noah LSM for the next UFS-SRW v2.1.0 app release. (2) to add CCPP Scientific Documentation updates for UFS-SRW v2.1.0

This PR adds a new regression test (RT) named regional_3km_wofs, which mainly follows the RT regional_3km. The settings for namelist parameters possibly have room to optimize. No baseline changes other than the newly added RT.

Testing

The RT regional_3km_wofs is a regional configuration at 3 km grid spacing. The ORT test was successful but only for dcp and thr. The current ORT for the regional configuration doesn't support mpi, rst and debug.
The log file for ORT test:
baseline dir = /scratch1/NCEPDEV/stmp4/Chunxi.Zhang/FV3_OPNREQ_TEST/OPNREQ_TEST/fv3_regional_3km_wofs_std_base
working dir = /scratch1/NCEPDEV/stmp2/Chunxi.Zhang/FV3_OPNREQ_TEST/opnReqTest_303105/regional_3km_wofs_dcp
Checking test dcp regional_3km_wofs results ....
Comparing dynf000.nc .........OK
Comparing dynf006.nc .........OK
Comparing phyf000.nc .........OK
Comparing phyf006.nc .........OK
Comparing PRSLEV.GrbF00 .........OK
Comparing PRSLEV.GrbF06 .........OK
Comparing NATLEV.GrbF00 .........OK
Comparing NATLEV.GrbF06 .........OK

0: The total amount of wall time = 559.146204
0: The maximum resident set size (KB) = 704192

Test dcp regional_3km_wofs PASS

baseline dir = /scratch1/NCEPDEV/stmp4/Chunxi.Zhang/FV3_OPNREQ_TEST/OPNREQ_TEST/fv3_regional_3km_wofs_std_base
working dir = /scratch1/NCEPDEV/stmp2/Chunxi.Zhang/FV3_OPNREQ_TEST/opnReqTest_303105/regional_3km_wofs_std_base
Checking test std_base regional_3km_wofs results ....
Moving baseline std_base regional_3km_wofs files ....
Moving dynf000.nc .........OK
Moving dynf006.nc .........OK
Moving phyf000.nc .........OK
Moving phyf006.nc .........OK
Moving PRSLEV.GrbF00 .........OK
Moving PRSLEV.GrbF06 .........OK
Moving NATLEV.GrbF00 .........OK
Moving NATLEV.GrbF06 .........OK

0: The total amount of wall time = 338.523577
0: The maximum resident set size (KB) = 629408

Test std_base regional_3km_wofs PASS

baseline dir = /scratch1/NCEPDEV/stmp4/Chunxi.Zhang/FV3_OPNREQ_TEST/OPNREQ_TEST/fv3_regional_3km_wofs_std_base
working dir = /scratch1/NCEPDEV/stmp2/Chunxi.Zhang/FV3_OPNREQ_TEST/opnReqTest_303105/regional_3km_wofs_thr
Checking test thr regional_3km_wofs results ....
Comparing dynf000.nc .........OK
Comparing dynf006.nc .........OK
Comparing phyf000.nc .........OK
Comparing phyf006.nc .........OK
Comparing PRSLEV.GrbF00 .........OK
Comparing PRSLEV.GrbF06 .........OK
Comparing NATLEV.GrbF00 .........OK
Comparing NATLEV.GrbF06 .........OK

0: The total amount of wall time = 233.675934
0: The maximum resident set size (KB) = 494200

Test thr regional_3km_wofs PASS

OPERATION REQUIREMENT TEST WAS SUCCESSFUL

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

  • waiting on noaa-emc/fv3atm/pull/<594>
  • waiting on ufs-community/ccpp-physics/pull/<14>

Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ChunxiZhang-NOAA ChunxiZhang-NOAA marked this pull request as ready for review October 21, 2022 15:03
@DeniseWorthen
Copy link
Collaborator

@ChunxiZhang-NOAA can we close the older PR (#1158)?

@ChunxiZhang-NOAA
Copy link
Contributor Author

@DeniseWorthen Yes, please close the old PR#1158.

@DeniseWorthen DeniseWorthen mentioned this pull request Oct 27, 2022
16 tasks
@jkbk2004 jkbk2004 added the Baseline Updates Current baselines will be updated. label Oct 28, 2022
@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA #1443 was merged. Once the branch gets synced, we can start working on this PR. @BrianCurtis-NOAA I will add new BL_DATE and start create new baseline for regional_3km_wofs.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@ChunxiZhang-NOAA #1443 was merged. Once the branch gets synced, we can start working on this PR. @BrianCurtis-NOAA I will add new BL_DATE and start create new baseline for regional_3km_wofs.

@jkbk2004 Ok, thanks. I will sync my branch ASAP.

@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA can you sync and resolve the conflict? so that we can start working on the PR.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 I am waiting for @mzhangw to sync her branch because ccpp-physics points to her branch.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 I've synced my branches. It is ready for the commit process.

@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA thanks! @BrianCurtis-NOAA I will manually create new baseline regional_3km_wofs and start testing from hera and cheyenne.

@BrianCurtis-NOAA BrianCurtis-NOAA changed the title Add a new RT for the SDF FV3_WoFS_v0 [FV3] Add a new RT for the SDF FV3_WoFS_v0 Oct 31, 2022
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@jkbk2004 jkbk2004 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Oct 31, 2022
@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 you can skip Acorn. It was testing OK when i last checked yesterday afternoon (tests still running), but couldn't get to the logs this AM due to machine limits for today.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 1, 2022

@ChunxiZhang-NOAA all tests are done. we can start merging in dependencies.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 Ok, ccpp-physics #14 was merged just now. I will change the pointer for fv3atm first.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 1, 2022

@ChunxiZhang-NOAA merged fv3atm pr 594. so with hash update and revert gitmodules, we can merge in this pr here.

@ChunxiZhang-NOAA
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants