CCPP Scientific Documentation updates for UFS-SRW v2.1.0 #14
Conversation
dustinswales
requested review from
gthompsnWRF,
Qingfu-Liu,
BantwaleEnyew-NOAA and
barlage
and removed request for
BantwaleEnyew-NOAA
|
@mzhangw Please merge in the latest ufs/dev branch of ccpp/physics when you get a chance. |
… into delta_srw210
|
@mzhangw Could you help to check if it can compile RT control_p8 successfully? git clone -b feature/srw_wofs --recursive https://github.com/ChunxiZhang-NOAA/ufs-weather-model.git It failed to compile. But if I check out ccpp-physics hash d93ce1a, it can compile successfully. |
|
I am kicking off RTs today and will let you know how it goes. |
|
@mzhangw Ok, thanks. |
|
@ChunxiZhang-NOAA It should be fixed now,i.e. control_p8 compiles and passes. This PR picks up another possible bug on the host model side: there is no nf_albd defined on the host model side. I have added it on /scratch1/BMC/gmtb/Man.Zhang/_srw_2_1_0_doc/ufs-weather-model/FV3/ccpp/data. Could you confirm it? Do I need to submit a PR at fv3atm? |
|
@mzhangw You don't need to open superrepository PRs. This is being pulled in with NOAA-EMC/fv3atm#594 |
|
OK, thanks. Once nf_albd is added in fv3atm, its definition in
module_radiation_surface could be omitted.
…On Tue, Oct 25, 2022 at 8:34 AM ChunxiZhang-NOAA ***@***.***> wrote:
@mzhangw <https://github.com/mzhangw> Thank you so much for fixing the
bug. Do you know why it didn't show up before this PR? I can add your
modification in the fv3atm PR#594
<NOAA-EMC/fv3atm#594>.
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TW2WTXGQC6BRYRQ5DWYDWE7VYHANCNFSM6AAAAAARFTX7TU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Agreed. And I think the dimension nf_albd can pass into setalb as an argument. So no radiation_surface.meta required anymore, and the definition/assignment of nf_albd can be removed in radiation_surface.f. |
|
I modified the code and did a quick test with control_p8. It passed regression test. I modified GFS_radiation_surface.F90 (meta), radiation_surface.f, and deleted radiation_surface.meta. The code is located at: /scratch1/NCEPDEV/hwrf/save/Chunxi.Zhang/mytest/ufs-weather-model/FV3/ccpp/physics/physics |
|
@mzhangw Is this PR ready to go? |
|
Yes, it looks good to me.
… On Oct 27, 2022, at 9:35 AM, ChunxiZhang-NOAA ***@***.***> wrote:
@mzhangw <https://github.com/mzhangw> Is this PR ready to go?
—
Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2U3RFXWOT7MRBMLQPTWFKONXANCNFSM6AAAAAARFTX7TU>.
You are receiving this because you were mentioned.
|
Good to know. Thanks. The commit process is scheduled to start tomorrow. |
|
@mzhangw Could you please make your branch update-to-date? |
… into delta_srw210
|
Done
… On Oct 30, 2022, at 7:54 PM, ChunxiZhang-NOAA ***@***.***> wrote:
@mzhangw <https://github.com/mzhangw> Could you please make your branch update-to-date?
—
Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2QBINEDNPINAAHD6XDWF4REZANCNFSM6AAAAAARFTX7TU>.
You are receiving this because you were mentioned.
|
Thank you! |
CCPP SciDoc updates for UFS-SRW v2.1.0 release. The website results can be viewed here.
@lisa-bengtsson @joeolson42 @gthompsnWRF
RTs pass on Hera.