Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new SDF named FV3_WoFS_v0 for SRW_v2.1 release #594

Merged
merged 10 commits into from
Nov 1, 2022

Conversation

ChunxiZhang-NOAA
Copy link
Contributor

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Oct 18, 2022

Description

This PR includes two main tasks:

  1. In favor of PR#514. All credit for code changes and description to @MicroTed. It adds an SDF for SRW app v2.1 release for WoFS (Warn on Forecast System). It is the same as the RRFS_v1nssl SDF except for using Noah LSM instead of NoahMP. This SDF was planned for use in the 2022 Spring Forecast Experiment. It will also be used for an option in the regional workflow.
  2. CCPP Scientific Documentation updates for UFS-SRW v2.1.0 #14. Note that it includes a minor bug fix to include variable nf_albd in the host model (CCPP_typedefs).

Testing

The description of the regression test is provided in the ufs-weather-model level PR#1460.

Dependencies

waiting on ufs-community/ccpp-physics/pull/#14

@ligiabernardet
Copy link

@ChunxiZhang-NOAA Thank you for this PR. Should a regression test be added so we can make sure this publicly released and supported suite does not break going forward?

@ChunxiZhang-NOAA
Copy link
Contributor Author

@ChunxiZhang-NOAA Thank you for this PR. Should a regression test be added so we can make sure this publicly released and supported suite does not break going forward?

@ligiabernardet Yes, the regression test is added here.

@ChunxiZhang-NOAA ChunxiZhang-NOAA marked this pull request as ready for review October 21, 2022 16:02
@ChunxiZhang-NOAA
Copy link
Contributor Author

@MicroTed Could you please review this PR.

@grantfirl
Copy link
Collaborator

@ChunxiZhang-NOAA As soon as you point the ccpp/physics pointer to ufs-community/ccpp-physics#14 in this PR, I'll get rid of the drafts in fv3atm/ufs-weather-model that I created for the docs update.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@MicroTed I noticed that GFS_suite_interstitial_4 is not in suite_FV3_RRFS_v1nssl.xml and suite_FV3_WoFS_v0.xml. There is part of code for "imp_physics == imp_physics_nssl" in GFS_suite_interstitial_4.F90. Do you know why it is not included in the suite definition file?

@grantfirl
Copy link
Collaborator

@MicroTed I noticed that GFS_suite_interstitial_4 is not in suite_FV3_RRFS_v1nssl.xml and suite_FV3_WoFS_v0.xml. There is part of code for "imp_physics == imp_physics_nssl" in GFS_suite_interstitial_4.F90. Do you know why it is not included in the suite definition file?

@ChunxiZhang-NOAA It is not needed. I asked @MicroTed the same question and here was his response (copied from email): "GFS_suite_interstitial_4 only does something specifically for NSSL-2mom if there are droplets or ice crystals injected by a convection parameterization. (Creates number concentration for the new particles.)"

Since there is no convection in this suite, there is no reason to call this interstitial in the WoFS suite.

@MicroTed
Copy link
Contributor

Yes, thanks for chiming in, @grantfirl -- If there is no parameterized convection, then the interstitial subroutines do nothing.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@grantfirl @MicroTed Thank you!

@ChunxiZhang-NOAA
Copy link
Contributor Author

@grantfirl I pointed the ccpp-physics pointer to Man's branch. Saw you have closed those draft PRs, haha.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 1, 2022

@DusanJovic-NOAA @RatkoVasic-NOAA all tests are done on ufs-wm pr 1460. This pr can be merged once @ChunxiZhang-NOAA revert gitmodules.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 jkbk2004 merged commit d6f5ccf into NOAA-EMC:develop Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants