Remove environment-ember-loose reexports
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR represents the first chunk of preparation for our breaking 0.8.0 release. It removes the custom reexports of
@glimmer/component,@ember/component/*andember-modifierfrom@glint/environment-ember-loose, as well as the utility types likeComponentLikethat were previously exposed there.The former should now be imported directly from their home packages, and the latter have been rehomed in
@glint/templateand updated to use standardized signature formats. See the Migrating docs for further details on this change.This change now requires recent versions of
@glimmer/component,ember-modifierand@types/ember__componentand declares appropriatepeerDependenciesaccordingly (which we really should have been doing before).Notes
Note that this PR doesn't update the README or docs site. The two need to be rationalized with one another (most likely paring down the README and pointing folks to the site), and I'll take that on in a follow-on PR.
This also doesn't touch
@glint/environment-glimmerx, as we currently don't have the flexibility we need in the types on the GlimmerX side. For the initial 0.8.0 release, we'll probably temporarily markenvironment-glimmerxas a private package so that no 0.8.0 version is published. Then once GlimmerX has been updated, we can make the necessary changes here and publish an 0.8.x version that includes support.