Upgrade Glimmer.js to beta 20 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Yea the ember-try tests are definitely unrelated they have been failing for a bit. Unfortunately I haven't been able to find time to bump ember-auto-import to fix the tests for interop between glimmerx and ember. |
dfreeman
force-pushed
the
upgrade-glimmer
branch
from
9f91a18
to
423c88a
Compare
|
@chiragpat I've bumped to beta 20 here, and I also have a branch that I think should get the ember interop tests working again as well. Unfortunately I can't separate that out from this diff because one of the things it requires to pass in Ember 4 is a more recent version of |
This was referenced Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the Glimmer.js dependencies to beta 20, and the Glimmer VM dependencies to 0.84 to match.
Betas 18-20 added support for the Component Signature RFC to
@glimmer/component, which makes integration with Glint much nicer for users, as it means they can use native imports.