Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added floppy icon ( Save ) #277

Closed
wants to merge 10 commits into from
Closed

Added floppy icon ( Save ) #277

wants to merge 10 commits into from

Conversation

psjishnu
Copy link
Contributor

@psjishnu psjishnu commented Jun 2, 2020

Added save icon ( floppy-fill )

Fixed Issue #272

@psjishnu
Copy link
Contributor Author

psjishnu commented Jun 2, 2020

screen

@psjishnu psjishnu closed this Jun 2, 2020
@psjishnu psjishnu reopened this Jun 2, 2020
@psjishnu psjishnu closed this Jun 2, 2020
@psjishnu psjishnu deleted the floppy-fill branch June 2, 2020 08:49
@psjishnu psjishnu restored the floppy-fill branch June 4, 2020 05:51
@psjishnu psjishnu reopened this Jun 4, 2020
@psjishnu
Copy link
Contributor Author

psjishnu commented Jun 4, 2020

Please mention how to update bootstrap-icons.svg file

@MrKuzio
Copy link

MrKuzio commented Jun 5, 2020

Hey, @psjishnu would you be able to review the shape of the icon?
It seems a bit too different from the shape of an actual floppy disc.

Also, I think another point of improvement would be to increase the thickness of the stroke on smaller sizes. SO the lines would still be visible.
It would be great if you could specify the size in pixel and to make it never smaller than 1px, and try to avoid as much as possible to make the stroke size become portions of pixels. This to avoid pixelation.

@mdo mdo changed the base branch from master to main June 26, 2020 18:06
@mdo mdo closed this Oct 28, 2020
@claviska claviska mentioned this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants