Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use btn-$variant-color variables for outlined btns #22164

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

intellix
Copy link
Contributor

Despite now having the ability to override outline-variant color, it's not actually being used so each are still #fff

I've set $btn-primary-color to #000 but noticed it was still #fff for outlined buttons because the var isn't passed into @mixin button-outline-variant

Related: #20734

Despite now having the ability to override outline-variant color, it's not actually being used so each are still #fff

Related: twbs#20734
@beausmith
Copy link
Contributor

👍 Nice @intellix! I had forgotten about this.

I recall that I hesitated in committing this change because it does have one visual change… and so I committed the smallest change with the goal of getting it merged, then coming back to this… but I got distracted. So, I'm glad you've made this commit!

The hover color for the secondary outline button is currently white, this commit changes it to the $gray-dark color. Arguably, this change of color makes the behavior more consistent to the default button normal and hover states (see below).

Outline buttons

Default:
image

Hover (before change):
image

Hover (after change):
image

While this does contain a visual change… it makes the secondary outline button hover state more visually similar to that of the default secondary button, adding more contrast to the text color vs background color:

Buttons

Default:
image

Hover:
image

I approve this change… however it may have minor affect on projects when they upgrade to use this code.

@mdo mdo modified the milestones: v4.0.0-beta.2, v4.0.0-beta Mar 13, 2017
@mdo mdo merged commit b3aa5ec into twbs:v4-dev Mar 13, 2017
@mdo mdo mentioned this pull request Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants