Remove hard-coded value in button-outline-variant #20734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes twbs#20609 PR twbs#20641, another solution to this issue, hard-codes use of $body-color, which may not be the desired color for the text when hovering.
This was referenced Oct 28, 2016
Closed
Closed
|
It seems that this isn't ever used. It always defaults to white which is the same as being hardcoded: https://github.com/twbs/bootstrap/blob/v4-dev/scss/_buttons.scss#L76 |
intellix
added a commit
to intellix/bootstrap-2
that referenced
this pull request
Mar 11, 2017
Despite now having the ability to override outline-variant color, it's not actually being used so each are still #fff Related: twbs#20734
This was referenced Mar 11, 2017
|
@intellix - I posted my answer to your question on your PR: #22164 (comment) |
mdo
pushed a commit
that referenced
this pull request
Mar 13, 2017
Despite now having the ability to override outline-variant color, it's not actually being used so each are still #fff Related: #20734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20609
PR #20641, another solution to this issue, hard-codes use of $body-color, which may not be the desired color for the text when hovering.
Before
After