do not show tab when disabled #20174
Conversation
|
|
||
| $(tabsHTML) | ||
| .find('li:last a') | ||
| .on('show.bs.tab', function (e) { |
There was a problem hiding this comment.
Unexpected function expression prefer-arrow-callback
'e' is defined but never used no-unused-vars
|
Is it better to fix the @houndci-bot comments or keep with the existing style of the test file? |
|
I guess you can ignore the hound issues. |
|
👍 happy to update the whole file so it passes hound. whatever I can I do to move v4 forward ⏩ |
|
|
||
| $(tabsHTML) | ||
| .find('li:last a') | ||
| .on('show.bs.tab', function () { |
There was a problem hiding this comment.
Unexpected function expression prefer-arrow-callback
|
attempted to fix @houndci-bot's comments but then tests broke because underlying phantomjs isn't new enough to handle ES2015 like |
| $(function () { | ||
| 'use strict'; | ||
| 'use strict' |
There was a problem hiding this comment.
Why did you remove the semicolon ?
There was a problem hiding this comment.
It's been awhile since I did this. most likely just following eslint prompts in atom
| @@ -150,6 +150,38 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <h4>Tabs with disabled tab</h4> | |||
There was a problem hiding this comment.
Why did you add a visuel test in addition of a unit test ? Currently visuel tests are usefull to show something impossible to test in unit tests
There was a problem hiding this comment.
I felt it was a clearer way to demonstrate and verify the fix
|
Closing as dupe of #20795. |
attempts to fix #19849