Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on disabled tab still shows corresponding pane #19849

Closed
Paladinium opened this issue May 6, 2016 · 2 comments
Closed

Click on disabled tab still shows corresponding pane #19849

Paladinium opened this issue May 6, 2016 · 2 comments
Labels
confirmed has-pr js v4

Comments

@Paladinium
Copy link

Using the tab JavaScript plugin with alpha v2, a disabled tab switches the tab content when being clicked. This bug can be seen in the documentation:

Expected: no tab switch happens when clicking on disabled tabs.

The JavaScript needs to take the 'disabled' CSS class (maybe also the 'disabled' attribute) on nav-link into account.
@RyanZim
Copy link

RyanZim commented May 6, 2016

Confirmed on the latest v4-dev branch. JSFiddle: https://jsfiddle.net/55rb3th9/.

@cvrebert cvrebert changed the title Click on disabled tab does tab switch Click on disabled tab still shows corresponding pane May 8, 2016
@cvrebert
Copy link
Collaborator

cvrebert commented May 8, 2016

X-Ref: #19031

maxbeatty added a commit to maxbeatty/bootstrap that referenced this issue Jun 25, 2016
@maxbeatty
do not show tab when disabled fixes twbs#19849
d74a9b9
@maxbeatty maxbeatty mentioned this issue Jun 25, 2016
Closed
@coorasse coorasse mentioned this issue Sep 27, 2016
Merged
@mdo mdo mentioned this issue Nov 28, 2016
Closed
7 tasks
@mdo mdo added the has-pr label Dec 23, 2016
mdo pushed a commit that referenced this issue Dec 25, 2016
@coorasse @mdo
[Fix #19849] Tabs are opened even if disabled. (#20795)
9103bff 
* [Fix #19849] Tabs are opened even if disabled.

* fix hund code review hints

* rollback hound issues because Travis fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed has-pr js v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdo @cvrebert @Paladinium @RyanZim