Round two of fixing #124 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedodd
commented
Feb 11, 2021
| .await | ||
| .context("error taking canonical path to cargo target dir")?; | ||
| let _ = chan.try_send(target_dir.into()); | ||
| let _ = chan.try_send(self.manifest.metadata.target_directory.clone()); | ||
| } |
There was a problem hiding this comment.
For those reviewing, self.manifest.metadata.target_directory always comes out of cargo_metadata as a canonical path.
thedodd
force-pushed
the
124-round-two
branch
from
a1b3ccb
to
0a6bd27
Compare
This time, the path was being canonicalized in another location. My original verification apparently did not account for this. All calls to `canonicalize` have been audited, and every location where such is called, it is also expected that the path exist, and is indeed considered an error if it does not exist.
thedodd
force-pushed
the
124-round-two
branch
from
0a6bd27
to
3c65df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time, the path was being canonicalized in another location. My
original verification apparently did not account for this.
All calls to
canonicalizehave been audited, and every location wheresuch is called, it is also expected that the path exist, and is indeed
considered an error if it does not exist.
closes #124
Checklist
Updated README.md with pertinent info (may not always apply).