Skip to content

Commit

Permalink
Round two of fixing #124
Browse files Browse the repository at this point in the history
This time, the path was being canonicalized in another location. My
original verification apparently did not account for this.

All calls to `canonicalize` have been audited, and every location where
such is called, it is also expected that the path exist, and is indeed
considered an error if it does not exist.
  • Loading branch information
thedodd committed Feb 14, 2021
1 parent 1a497f5 commit 3c65df6
Show file tree
Hide file tree
Showing 8 changed files with 155 additions and 162 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,8 @@ jobs:
- name: Build | Run
run: cargo run -- -h

# TODO: finish this up as part of #57
# # build examples via our newly built debug artifact
# - name: Setup | wasm-bindgen
# run: cargo install wasm-bindgen-cli --version 0.2.70
# - name: Build | Examples
# run: ${{ matrix.binPath }} --config=examples/yew/Trunk.toml build
# Build examples via our newly built debug artifact.
- name: Setup | wasm-bindgen
run: cargo install wasm-bindgen-cli --version 0.2.70
- name: Build | Examples
run: ${{ matrix.binPath }} --config=examples/yew/Trunk.toml build
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Subheadings to categorize changes are `added, changed, deprecated, removed, fixe

## Unreleased

## 0.8.1
## 0.8.2 & 0.8.1
### fixed
- Fixed [#124](https://github.com/thedodd/trunk/issues/124) where path canonicalization was being performed on a path which did not yet exist, and as it turns out was already in canonical form.

Expand Down
105 changes: 58 additions & 47 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "trunk"
version = "0.8.1"
version = "0.8.2"
edition = "2018"
description = "Build, bundle & ship your Rust WASM application to the web."
license = "MIT/Apache-2.0"
Expand Down
Loading

0 comments on commit 3c65df6

Please sign in to comment.