ext/jaeger: export span kind (open-telemetry#387)

Encode the span kind as a "span.kind" tag.
toumorokoshi · Feb 17, 2020 · 052ae1b · 052ae1b
1 parent 69916fa
commit 052ae1b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/ext/opentelemetry-ext-jaeger/CHANGELOG.md b/ext/opentelemetry-ext-jaeger/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Export span status ([#367](https://github.com/open-telemetry/opentelemetry-python/pull/367))
+- Export span kind ([#387](https://github.com/open-telemetry/opentelemetry-python/pull/387))
 
 ## 0.3a0
 

diff --git a/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py b/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py
@@ -160,6 +160,7 @@ def _translate_to_jaeger(spans: Span):
             [
                 _get_long_tag("status.code", status.canonical_code.value),
                 _get_string_tag("status.message", status.description),
+                _get_string_tag("span.kind", span.kind.name),
             ]
         )
 

diff --git a/ext/opentelemetry-ext-jaeger/tests/test_jaeger_exporter.py b/ext/opentelemetry-ext-jaeger/tests/test_jaeger_exporter.py
@@ -156,7 +156,7 @@ def test_translate_to_jaeger(self):
             context=other_context, attributes=link_attributes
         )
 
-        default_status_tags = [
+        default_tags = [
             jaeger.Tag(
                 key="status.code",
                 vType=jaeger.TagType.LONG,
@@ -165,6 +165,11 @@ def test_translate_to_jaeger(self):
             jaeger.Tag(
                 key="status.message", vType=jaeger.TagType.STRING, vStr=None,
             ),
+            jaeger.Tag(
+                key="span.kind",
+                vType=jaeger.TagType.STRING,
+                vStr=trace_api.SpanKind.INTERNAL.name,
+            ),
         ]
 
         otel_spans = [
@@ -174,6 +179,7 @@ def test_translate_to_jaeger(self):
                 parent=parent_context,
                 events=(event,),
                 links=(link,),
+                kind=trace_api.SpanKind.CLIENT,
             ),
             trace.Span(
                 name=span_names[1], context=parent_context, parent=None
@@ -234,6 +240,11 @@ def test_translate_to_jaeger(self):
                         vType=jaeger.TagType.STRING,
                         vStr="Example description",
                     ),
+                    jaeger.Tag(
+                        key="span.kind",
+                        vType=jaeger.TagType.STRING,
+                        vStr=trace_api.SpanKind.CLIENT.name,
+                    ),
                     jaeger.Tag(
                         key="error", vType=jaeger.TagType.BOOL, vBool=True,
                     ),
@@ -283,7 +294,7 @@ def test_translate_to_jaeger(self):
                 startTime=start_times[1] // 10 ** 3,
                 duration=durations[1] // 10 ** 3,
                 flags=0,
-                tags=default_status_tags,
+                tags=default_tags,
             ),
             jaeger.Span(
                 operationName=span_names[2],
@@ -294,7 +305,7 @@ def test_translate_to_jaeger(self):
                 startTime=start_times[2] // 10 ** 3,
                 duration=durations[2] // 10 ** 3,
                 flags=0,
-                tags=default_status_tags,
+                tags=default_tags,
             ),
         ]