Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/jaeger: add span kind jaeger exporter #387

Merged

Conversation

mauriciovasquezbernal
Copy link
Member

Fixes #369.

Export the span kind as "span.kind" tag.

This PR contains #367, so it should be merged after it.

@mauriciovasquezbernal mauriciovasquezbernal requested a review from a team January 28, 2020 22:59
@mauriciovasquezbernal mauriciovasquezbernal force-pushed the mauricio/add-span-kind-jaeger-exporter branch from 8b68ad7 to 6a00b71 Compare January 28, 2020 22:59
@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

Merging #387 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files          38       38           
  Lines        1925     1925           
  Branches      226      226           
=======================================
  Hits         1643     1643           
  Misses        218      218           
  Partials       64       64
Impacted Files Coverage Δ
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py 86.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3995075...0c4e57e. Read the comment docs.

Encode the span kind as a "span.kind" tag.
@mauriciovasquezbernal mauriciovasquezbernal force-pushed the mauricio/add-span-kind-jaeger-exporter branch from 6a00b71 to 0c4e57e Compare January 29, 2020 15:33
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c24t c24t merged commit 682ecc2 into open-telemetry:master Jan 30, 2020
toumorokoshi pushed a commit to toumorokoshi/opentelemetry-python that referenced this pull request Feb 17, 2020
Encode the span kind as a "span.kind" tag.
@mauriciovasquezbernal mauriciovasquezbernal deleted the mauricio/add-span-kind-jaeger-exporter branch April 14, 2020 21:51
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger Exporter does not handle SpanKind
4 participants