fix: note height less than minimum height #6717
test.yml
on: pull_request
Install Dependencies
36s
Build & Test
0s
Annotations
8 errors, 20 warnings, and 20 notices
selection/native.spec.ts:289:1 › cursor move to up and down with children block:
tests/selection/native.spec.ts#L318
1) selection/native.spec.ts:289:1 › cursor move to up and down with children block ───────────────
Error: expect(received).toBeGreaterThanOrEqual(expected)
Expected: >= 12
Received: -1
316 | const textTwo = await getInlineSelectionText(page);
317 | expect(textTwo).toBe('arrow down test 1');
> 318 | expect(indexTwo).toBeGreaterThanOrEqual(12);
| ^
319 | expect(indexTwo).toBeLessThanOrEqual(17);
320 | await page.keyboard.press('ArrowDown');
321 | const textThree = await getInlineSelectionText(page);
at /home/runner/work/blocksuite/blocksuite/tests/selection/native.spec.ts:318:20
|
attachment.spec.ts:406:1 › should attachment can be deleted:
tests/attachment.spec.ts#L69
1) attachment.spec.ts:406:1 › should attachment can be deleted ───────────────────────────────────
TimeoutError: page.waitForEvent: Timeout 5000ms exceeded while waiting for event "filechooser"
=========================== logs ===========================
waiting for event "filechooser"
============================================================
67 | await expect(slashMenu).toBeVisible();
68 |
> 69 | const fileChooser = page.waitForEvent('filechooser');
| ^
70 | await pressEnter(page);
71 | await sleep(100);
72 | await (await fileChooser).setFiles(FILE_PATH);
at insertAttachment (/home/runner/work/blocksuite/blocksuite/tests/attachment.spec.ts:69:30)
at /home/runner/work/blocksuite/blocksuite/tests/attachment.spec.ts:412:3
|
attachment.spec.ts:725:1 › attachment can be dragged from note to surface top level block:
tests/attachment.spec.ts#L69
2) attachment.spec.ts:725:1 › attachment can be dragged from note to surface top level block ─────
TimeoutError: page.waitForEvent: Timeout 5000ms exceeded while waiting for event "filechooser"
=========================== logs ===========================
waiting for event "filechooser"
============================================================
67 | await expect(slashMenu).toBeVisible();
68 |
> 69 | const fileChooser = page.waitForEvent('filechooser');
| ^
70 | await pressEnter(page);
71 | await sleep(100);
72 | await (await fileChooser).setFiles(FILE_PATH);
at insertAttachment (/home/runner/work/blocksuite/blocksuite/tests/attachment.spec.ts:69:30)
at /home/runner/work/blocksuite/blocksuite/tests/attachment.spec.ts:733:3
|
edgeless/note/note.spec.ts:255:1 › duplicate note should work correctly:
tests/edgeless/note/note.spec.ts#L280
1) edgeless/note/note.spec.ts:255:1 › duplicate note should work correctly ───────────────────────
Error: expect(received).toBeCloseTo(expected)
Expected: 446.51165771484375
Received: 517.2093048095703
Expected precision: 2
Expected difference: < 0.005
Received difference: 70.69764709472656
278 | const firstNoteBox = await firstNote.boundingBox();
279 | const secondNoteBox = await secondNote.boundingBox();
> 280 | expect(firstNoteBox!.width).toBeCloseTo(secondNoteBox!.width);
| ^
281 | expect(firstNoteBox!.height).toBeCloseTo(secondNoteBox!.height);
282 | });
283 |
at /home/runner/work/blocksuite/blocksuite/tests/edgeless/note/note.spec.ts:280:31
|
hotkey/hotkey.spec.ts:258:1 › should cut work single line:
tests/hotkey/hotkey.spec.ts#L267
1) hotkey/hotkey.spec.ts:258:1 › should cut work single line ─────────────────────────────────────
Error: Snapshot comparison failed:
{
"type": "block",
"id": "0",
"flavour": "affine:page",
"version": 2,
"props": {
"title": {
"$blocksuite:internal:text$": true,
"delta": []
}
},
"children": [
{
"type": "block",
"id": "1",
"flavour": "affine:note",
"version": 1,
"props": {
"xywh": "[0,0,800,95]",
"background": "--affine-note-background-white",
"index": "a0",
"hidden": false,
"displayMode": "both",
"edgeless": {
"style": {
"borderRadius": 8,
"borderSize": 4,
"borderStyle": "none",
"shadowType": "--affine-note-shadow-box"
}
}
},
"children": [
{
"type": "block",
"id": "2",
"flavour": "affine:paragraph",
"version": 1,
"props": {
"type": "text",
"text": {
"$blocksuite:internal:text$": true,
"delta": [
{
"insert": "hello"
}
]
}
},
"children": []
}
]
}
]
}
Expected: /home/runner/work/blocksuite/blocksuite/tests/snapshots/hotkey/hotkey.spec.ts/should-cut-work-single-line-init.json
Received: /home/runner/work/blocksuite/blocksuite/tests/test-results/hotkey-hotkey-should-cut-work-single-line/should-cut-work-single-line-init-actual.json
265 | // cut
266 | await page.keyboard.press(`${SHORT_KEY}+x`);
> 267 | expect(await getPageSnapshot(page, true)).toMatchSnapshot(
| ^
268 | `${testInfo.title}_init.json`
269 | );
270 | await undoByKeyboard(page);
at /home/runner/work/blocksuite/blocksuite/tests/hotkey/hotkey.spec.ts:267:45
|
hotkey/multiline.spec.ts:100:1 › should cut work multiple line:
tests/hotkey/multiline.spec.ts#L110
2) hotkey/multiline.spec.ts:100:1 › should cut work multiple line ────────────────────────────────
Error: Snapshot comparison failed:
{
"type": "block",
"id": "0",
"flavour": "affine:page",
"version": 2,
"props": {
"title": {
"$blocksuite:internal:text$": true,
"delta": []
}
},
"children": [
{
"type": "block",
"id": "1",
"flavour": "affine:note",
"version": 1,
"props": {
"xywh": "[0,0,800,95]",
"background": "--affine-note-background-white",
"index": "a0",
"hidden": false,
"displayMode": "both",
"edgeless": {
"style": {
"borderRadius": 8,
"borderSize": 4,
"borderStyle": "none",
"shadowType": "--affine-note-shadow-box"
}
}
},
"children": [
{
"type": "block",
"id": "2",
"flavour": "affine:paragraph",
"version": 1,
"props": {
"type": "text",
"text": {
"$blocksuite:internal:text$": true,
"delta": [
{
"insert": "123"
}
]
}
},
"children": []
},
{
"type": "block",
"id": "3",
"flavour": "affine:paragraph",
"version": 1,
"props": {
"type": "text",
"text": {
"$blocksuite:internal:text$": true,
"delta": [
{
"insert": "456"
}
]
}
},
"children": []
},
{
"type": "block",
"id": "4",
"flavour": "affine:paragraph",
"version": 1,
"props": {
"type": "text",
"text": {
"$blocksuite:internal:text$": true,
"delta": [
{
"insert": "789"
}
]
}
},
"children": []
}
]
}
]
}
Expected: /home/runner/work/blocksuite/blocksuite/tests/snapshots/hotkey/multiline.spec.ts/should-cut-work-multiple-line-init.json
Received: /home/runner/work/blocksuite/blocksuite/tests/test-results/hotkey-multiline-should-cut-work-multiple-line/should-cut-work-multiple-line-init-actual.json
108 | // cut
109 | await page.keyboard.press(`${SHORT_KEY}+x`);
> 110 | expect(await getPageSnapshot(page, true)).toMatchSnapshot(
| ^
111 | `${testInfo.title}_init.json`
112 | );
113 | await undoByKeyboard(page);
at /home/runner/work/blocksuite/blocksuite/tests/hotkey/multiline.spec.ts:110:45
|
edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing:
tests/utils/actions/edgeless.ts#L357
1) edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing ─────────────────────────
TimeoutError: locator.click: Timeout 5000ms exceeded.
Call log:
- waiting for locator('edgeless-tool-icon-button').filter({ hasText: 'Square' })
- locator resolved to <edgeless-tool-icon-button role="button">…</edgeless-tool-icon-button>
- attempting click action
- waiting for element to be visible, enabled and stable
- element is not stable
- retrying click action, attempt #1
- waiting for element to be visible, enabled and stable
- element is not stable
- retrying click action, attempt #2
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is not stable
- retrying click action, attempt #3
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element was detached from the DOM, retrying
at utils/actions/edgeless.ts:357
355 | .locator('edgeless-tool-icon-button')
356 | .filter({ hasText: shape });
> 357 | await squareShapeButton.click();
| ^
358 | break;
359 | }
360 | }
at setEdgelessTool (/home/runner/work/blocksuite/blocksuite/tests/utils/actions/edgeless.ts:357:31)
at /home/runner/work/blocksuite/blocksuite/tests/edgeless/shortcut.spec.ts:137:3
|
edgeless/note/drag-handle.spec.ts:122:1 › drag handle should work across multiple notes:
tests/edgeless/note/drag-handle.spec.ts#L141
1) edgeless/note/drag-handle.spec.ts:122:1 › drag handle should work across multiple notes ───────
Error: Timed out 5000ms waiting for expect(locator).toBeHidden()
Locator: locator('.affine-drag-handle-container')
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 5000ms
- waiting for locator('.affine-drag-handle-container')
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
- locator resolved to <div class="affine-drag-handle-container">…</div>
- unexpected value "visible"
139 | await page.mouse.dblclick(CENTER_X, CENTER_Y - 20);
140 | await dragHandleFromBlockToBlockBottomById(page, '3', '7');
> 141 | await expect(page.locator('.affine-drag-handle-container')).toBeHidden();
| ^
142 | await waitNextFrame(page);
143 | await assertRichTexts(page, ['456', '789', '000', '123']);
144 |
at /home/runner/work/blocksuite/blocksuite/tests/edgeless/note/drag-handle.spec.ts:141:63
|
E2E Test (20)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (2)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (15)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (16)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (4)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (18)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (17)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (3)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (19)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (1)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (13)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (10)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (14)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (12)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (6)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (11)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (7)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (5)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (8)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
E2E Test (9)
Codecov:
Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
🎭 Playwright Run Summary
3 skipped
43 passed (41.3s)
|
🎭 Playwright Run Summary
1 skipped
46 passed (43.2s)
|
🎭 Playwright Run Summary
2 skipped
44 passed (54.4s)
|
🎭 Playwright Run Summary
46 passed (52.6s)
|
🎭 Playwright Run Summary
47 passed (54.9s)
|
🎭 Playwright Run Summary
46 passed (52.8s)
|
🎭 Playwright Run Summary
46 passed (43.1s)
|
🎭 Playwright Run Summary
4 skipped
43 passed (55.1s)
|
🎭 Playwright Run Summary
1 flaky
selection/native.spec.ts:289:1 › cursor move to up and down with children block ────────────────
45 passed (55.8s)
|
🎭 Playwright Run Summary
2 flaky
attachment.spec.ts:406:1 › should attachment can be deleted ────────────────────────────────────
attachment.spec.ts:725:1 › attachment can be dragged from note to surface top level block ──────
45 passed (59.7s)
|
🎭 Playwright Run Summary
47 passed (1.1m)
|
🎭 Playwright Run Summary
1 flaky
edgeless/note/note.spec.ts:255:1 › duplicate note should work correctly ────────────────────────
46 passed (1.2m)
|
🎭 Playwright Run Summary
2 flaky
hotkey/hotkey.spec.ts:258:1 › should cut work single line ──────────────────────────────────────
hotkey/multiline.spec.ts:100:1 › should cut work multiple line ─────────────────────────────────
45 passed (59.4s)
|
🎭 Playwright Run Summary
1 flaky
edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing ──────────────────────────
2 skipped
44 passed (1.1m)
|
🎭 Playwright Run Summary
47 passed (1.3m)
|
🎭 Playwright Run Summary
1 skipped
46 passed (1.5m)
|
🎭 Playwright Run Summary
47 passed (1.6m)
|
🎭 Playwright Run Summary
47 passed (1.5m)
|
🎭 Playwright Run Summary
47 passed (1.7m)
|
🎭 Playwright Run Summary
1 flaky
edgeless/note/drag-handle.spec.ts:122:1 › drag handle should work across multiple notes ────────
10 skipped
36 passed (1.5m)
|