Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: note height less than minimum height #8542

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: note height less than minimum height #8542

merged 1 commit into from
Oct 16, 2024
+192 −39

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented Oct 16, 2024 •
edited
Loading

Fix issue BS-1615.

What changed?

  • Unify initialization height and minimum height
  • Update collapsedHeight after clamp bound height
  • Add e2e test

截屏2024-10-16 17.40.14.png

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 11:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 11:47am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: abcd2c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@akumatus Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @akumatus and the rest of your teammates on Graphite Graphite

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 16, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit abcd2c6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.06 MB (-0.01% 🔽)
@blocksuite/affine/block-std 154.56 KB (0%)
@blocksuite/affine/block-std/gfx 77.47 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.82 KB (0%)
@blocksuite/affine/global/env 210 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.57 KB (0%)
@blocksuite/affine/inline 32.11 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.86 MB (+0.05% 🔺)
@blocksuite/affine/blocks 1.95 MB (+0.05% 🔺)
@blocksuite/affine/blocks/schemas 87.62 KB (0%)

@akumatus akumatus marked this pull request as ready for review October 16, 2024 09:44
@akumatus akumatus requested a review from a team as a code owner October 16, 2024 09:44
Saul-Mirone
Saul-Mirone approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Saul-Mirone Graphite App
Copy link
Collaborator

Saul-Mirone commented Oct 16, 2024 •
edited
Loading

Merge activity

  • Oct 16, 7:45 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 16, 7:45 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 16, 7:49 AM EDT: A user merged this pull request with the Graphite merge queue.

@akumatus
fix: note height less than minimum height (#8542)
abcd2c6 
Fix issue [BS-1615](https://linear.app/affine-design/issue/BS-1615).

### What changed?
- Unify initialization height and minimum height
- Update `collapsedHeight` after clamp bound height
- Add e2e test

![截屏2024-10-16 17.40.14.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/sJGviKxfE3Ap685cl5bj/009d0ce5-31ca-49c1-ba73-7f014493bc68.png)
@graphite-app graphite-app bot merged commit abcd2c6 into master Oct 16, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fix/note-min-height branch October 16, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

@Flrande Flrande Awaiting requested review from Flrande

@fundon fundon Awaiting requested review from fundon

Assignees

@akumatus akumatus

Labels
merge
Projects
BlockSuite Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akumatus @Saul-Mirone