Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't misinterpret colors as dates #559

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Don't misinterpret colors as dates #559

merged 4 commits into from
Mar 23, 2022

Commits on Mar 9, 2019

  1. Don't misinterpret colors as dates (fixes tidyverse#388)

    @nacnudus
    nacnudus committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    5b877b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Incorporate some updates

    @jennybc
    jennybc committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    b8a7f2d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into nacnudus-color-date

    @jennybc
    jennybc committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    478655a View commit details
    Browse the repository at this point in the history

  3. Add a test; tweak some tests 

    Add a test and test file based on a format where the confusion can come via currency, not colour.

Link to issues.

We generally incorporate `-xls` or `-xlsx` into test file names, so the format is obvious even if the file is open in Excel.

Added the actual implicit number formats in comments.
    @jennybc
    jennybc committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    bad832c View commit details
    Browse the repository at this point in the history